Page MenuHomePhabricator

VisualEditor: Phantoms are appearing at wrong place while selecting an image after making it fullsize
Closed, ResolvedPublic

Description

Phantoms appearing in wrong position

Steps to reproduce:

1.Open a page with VE
2.Insert an image which has large enough original size to go beyond the page say for example: http://en.wikipedia.beta.wmflabs.org/wiki/File:Ho-Ho-Kus_Inn.jpg

3.Make it full size
4.Save the page

5.Reopen the editor
6.Select the image by clicking on a but further from the border of the image

Observed Result:
The phantom for selection is appearing in the wrong position

See the screenshots attached

Now to observe some additional behavior:
Set the image size back to default size and observe the shield is still appearing in the previous position in the page


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-03-05_at_2.19.28_PM.png (683×1 px, 1 MB)

Details

Reference
bz62284

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:02 AM
bzimport set Reference to bz62284.

Created attachment 14749
How it appears when you select by clicking close to the border of the image

Attached:

Screen_Shot_2014-03-05_at_2.19.38_PM.png (472×1 px, 1019 KB)

Created attachment 14750
Phantom appearing in previous position after reverting it to default size

Attached:

Screen_Shot_2014-03-05_at_2.22.10_PM.png (544×1 px, 162 KB)

It the phantom remains in the previous position even if I close the editor and reopen it .

Selecting the phantom also selects the image below it.

Please go to this page to better understand the issue:
http://en.wikipedia.beta.wmflabs.org/w/index.php?title=5thfebchrome&veaction=edit

This also happens when I change the image position from Left to Center

I am not getting the phantom appearing at wrong position issue anymore ,but what I am see now is, it takes two clicks to select that image when you have made it full size.
If it is an unrelated issue , i will file a separate bug.

(In reply to ryasmeen from comment #5)

I am not getting the phantom appearing at wrong position issue anymore ,but
what I am see now is, it takes two clicks to select that image when you have
made it full size.
If it is an unrelated issue , i will file a separate bug.

Let's keep it in this one.

I can't replicate this. I think this was fixed after the refactor of the phantoms.

I think this issue is fixed now, the only issue I see now is, for image with too big size which goes beyond CE, the phantom is also going beyond the page.Not sure if that is something we can fix or not.