Page MenuHomePhabricator

VisualEditor: Block slugs don't shrink back when selection moves to a FocusableNode
Closed, ResolvedPublic

Description

  1. Click in a block slug
  2. The slug expands
  3. Click in another paragraph
  4. The slug contracts, as expected
  5. Click in the slug again
  6. The slug expands
  7. Click on a FocusableNode (reference, template, etc.)
  8. The slug doesn't contract
  9. Click in a paragraph somewhere
  10. Now the slug does contract

This is because contracting the slug when it's unfocused happens in pollOnceInternal, which is not invoked when selecting FocusableNodes (and only invoked by accident when changing the selection programmatically). onModelSelect in ce.Surface should probably clear the focusedness of the focused slug.


Version: unspecified
Severity: normal

Details

Reference
bz62285