Page MenuHomePhabricator
Create Task
Maniphest T64292

Neutral mw-ui-button is bigger than constructive/progressive buttons
Closed, ResolvedPublic
Actions

Description

Neutral buttons are 1px larger in all directions due to outsize border https://www.dropbox.com/s/w0t83ajadxf2a1j/Screenshot%202014-03-05%2014.36.31.png

Version: 1.23.0
Severity: trivial

Details

Reference
bz62292

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:03 AM
• bzimport added projects: MW-1.23.0-release, MediaWiki-User-Interface.
• bzimport set Reference to bz62292.
• Spage created this task.Mar 6 2014, 12:04 AM
• Mattflaschen-WMF added a comment.Mar 6 2014, 4:23 AM

Ryan Kaldari and I were discussing earlier that it might work to have a transparent 1px border on the other types.

gerritbot added a comment.Mar 7 2014, 4:19 AM

Change 117107 had a related patch set uploaded by Mattflaschen:
Make .mw-ui-button height the same for all buttons

https://gerrit.wikimedia.org/r/117107

• Mattflaschen-WMF added a comment.Mar 7 2014, 5:09 AM

Created attachment 14767
Screenshot showing minor bevel issue with patch

Attached:

mediawiki.ui.button_sizes_with_height_fix_truncated_bevel.png (95×313 px, 4 KB)

gerritbot added a comment.Apr 8 2014, 2:21 AM

Change 117107 had a related patch set uploaded by Mattflaschen:
Make .mw-ui-button height the same for all buttons

https://gerrit.wikimedia.org/r/117107

matmarex added a comment.Apr 12 2014, 1:33 PM

Merged.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL