Page MenuHomePhabricator

WikidataJenkins doesnt seem to correctly clean the workspace between tests / checkouts of mediawiki
Closed, ResolvedPublic

Description

Once https://gerrit.wikimedia.org/r/#/c/117441/ was merged into core where 2 files are renammed tests failed with the following...

http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-api-tests/776/ : FAILURE
http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-repo-tests/775/ : FAILURE
http://wikidata-jenkins.wmflabs.org/ci/job/wikidata-client-tests/802/ : FAILURE
for example on https://gerrit.wikimedia.org/r/#/c/117463/

This was due to both the old and new files from the rename in core existing in the workspace.! This is bad and shouldn't happen!

I logged into the instance and deleted the specific files causing an issue this time but we should probably just have jenkins do it right first time round otherwise this issue will keep popping back up!


Version: unspecified
Severity: normal

Details

Reference
bz62403

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
bzimport set Reference to bz62403.
bzimport added a subscriber: Unknown Object (MLST).

Seems that the workspace was not wiped out completely. The GIT Plugin has a setting to "clean" the workspace, but this does not include files which are not pulled by the plugin (MW core in this case..).
I added anther plugin that now cleans the whole workspace before running the job: https://wiki.jenkins-ci.org/display/JENKINS/Workspace+Cleanup+Plugin

Please reopen the bug if this does not solve the issue.