Get rid of native template expansion support being used for parser tests
Open, MediumPublic
Actions

Assigned To

None

Authored By

	ssastry
	Mar 8 2014, 3:10 AM

Description

From: https://gerrit.wikimedia.org/r/#/c/117211/2/lib/ext.core.Sanitizer.js

"We won't ever do anything fancy with the token-based template expansion. The only remaining use case is parserTests. At some point we should probably remove it and replace it with a mock string-based preprocessor."

This will simplify the codebase.

We can use the mockAPI to return the expected preprocessor response for the various expansions.

Version: unspecified
Severity: normal

Details

Reference: bz62424

	Subject	Repo	Branch	Lines +/-
	[WIP] Get rid of native template expansion	mediawiki/services/parsoid	master	+563 -1 K

Customize query in gerrit

Related Objects

Mentioned In: T164384: Parsoid does not handle SOL correctly in native template expansion
T115461: Testing: Verify mock API responses against mediawiki API responses

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM

• bzimport added a project: Parsoid.

• bzimport set Reference to bz62424.

ssastry created this task.Mar 8 2014, 3:10 AM

Arlolra removed • GWicke as the assignee of this task.Nov 25 2014, 7:56 PM

Arlolra set Security to None.

Arlolra triaged this task as Medium priority.Nov 26 2014, 12:03 AM

Arlolra subscribed.

ssastry added a project: Parsoid-Tests.Dec 10 2014, 7:47 AM

The mock preprocessor should be implemented in the mock MW API server we already have, so could just deal with one way of expanding in TemplateHandler.

ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 20 2014, 4:16 AM

• marcoil moved this task from Testing to Needs Triage on the Parsoid board.Feb 13 2015, 12:51 PM

ssastry mentioned this in T115461: Testing: Verify mock API responses against mediawiki API responses.Oct 14 2015, 12:53 PM

Arlolra claimed this task.Oct 16 2015, 3:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 16 2015, 3:45 PM

Arlolra removed Arlolra as the assignee of this task.Dec 21 2016, 1:21 AM

ssastry renamed this task from Implement string preprocessing for parser tests and get rid of native template expansion support to Get rid of native template expansion support being used for parser tests.May 3 2017, 3:36 PM

ssastry updated the task description. (Show Details)

cscott mentioned this in T164384: Parsoid does not handle SOL correctly in native template expansion.May 3 2017, 3:45 PM

Arlolra claimed this task.May 16 2017, 6:02 PM

Change 354151 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] [WIP] Get rid of native template expansion

https://gerrit.wikimedia.org/r/354151

gerritbot added a project: Patch-For-Review.May 17 2017, 8:20 PM

Change 354151 abandoned by Arlolra:
[WIP] Get rid of native template expansion

Reason:
Will pick this up later ...

https://gerrit.wikimedia.org/r/354151

Arlolra removed a project: Patch-For-Review.Dec 11 2017, 10:52 PM

ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 18 2017, 10:08 PM

Arlolra removed Arlolra as the assignee of this task.Feb 22 2018, 11:26 PM

ssastry moved this task from Testing to Tech Debt / Big changes on the Parsoid board.Jun 9 2020, 10:57 PM

ssastry merged a task: T164384: Parsoid does not handle SOL correctly in native template expansion.

ssastry added a subscriber: cscott.