wbeditentity permits claim property to be changed, however the diff doesnt display correctly
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	jayvdb
	Mar 8 2014, 4:17 AM

Description

An API call to wbeditentity, that uses the existing claim guid, is able to change the property of the claim.

See

In the diff, the presentation assumes the property of the claim is the same before and after.

However in the previous revision, there was a 'title' claim. In the modified revision, there is a 'birth name' claim.

Either the API or the Diff logic is wrong.

Version: unspecified
Severity: critical
Whiteboard: u=dev c=backend p=5 s=2014-04-01

		Status	Subtype	Assigned	Task
		Open		None	T64927 Perform input validation based on ChangeOp (tracking)
		Resolved		None	T64425 wbeditentity permits claim property to be changed, however the diff doesnt display correctly

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:53 AM

• bzimport set Reference to bz62425.

• bzimport added a subscriber: Unknown Object (MLST).

It would seem the Diff logic is wrong :)

It should not be possible to change the property.

Change 120537 had a related patch set uploaded by Daniel Kinzler:
(bug 62425) Property of main snak must not change.

note, it's also possible to add a snak with mismatching property data type and data value

Change 120537 merged by jenkins-bot:
(bug 62425) Property of main Snak must not change

(In reply to Aude from comment #5)

note, it's also possible to add a snak with mismatching property data type
and data value

this will be solved by bug 62644