Page MenuHomePhabricator
Create Task
Maniphest T64513

Create mw.Api.plugin.upload for uploading from MediaWiki frontend code
Closed, ResolvedPublic
Actions

Description

I wasn't able to find a bug for this.

Core has the server part of the upload API (including handling stashing, etc.). However, the clientside part is in UploadWizard.

This should be moved to core, at the correct abstraction level (promises, etc.), then UploadWizard should use that.

From T103397:

This should come with a proof-of-concept gadget that can be used to test the new API.

Version: 1.23.0
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54724
https://bugzilla.wikimedia.org/show_bug.cgi?id=60002

Details

Reference
bz62513
SubjectRepoBranchLines +/-
Add frontend API for uploading via iframemediawiki/coremaster+242 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:59 AM
• bzimport added a project: MediaWiki-Uploading.
• bzimport set Reference to bz62513.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Mar 10 2014, 9:59 PM
• brion added a comment.Mar 13 2014, 12:08 AM

MobileFrontend also has an uploading client implementation; are you thinking of some sort of low-level JS API wrapping file uploads that could be used by both, or specifically the high-level UploadWizard UI?

• Mattflaschen-WMF added a comment.Mar 21 2014, 8:19 PM

(In reply to Brion Vibber from comment #1)

MobileFrontend also has an uploading client implementation; are you thinking
of some sort of low-level JS API wrapping file uploads that could be used by
both, or specifically the high-level UploadWizard UI?

The actual low-level, client, upload part. It should abstract away the transport, and support chunked uploads if the user has it enabled. It shouldn't include UI, but it should make such UIs possible (callbacks for completion, failure, progress).

Basically some version of ApiUpload* (see also the Transport and Handler ones, like https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUploadWizard.git/HEAD/resources%2Fmw.FormDataTransport.js from https://git.wikimedia.org/tree/mediawiki%2Fextensions%2FUploadWizard.git/HEAD/resources .

It doesn't need to include all the UW stuff (e.g. Firefogg is probably not neeeded), just enough to get the job done with reasonable browser compatibility.

However, unlike UW, it should be in core and correctly abstracted (e.g. no transport.uploadObject.ui.setStatus in low-level code). UploadWizard, MobileFrontend, PronunciationRecording, and probably other stuff I'm not thinking of should all be able to use it.

Bawolff added a comment.Mar 21 2014, 8:38 PM

I would suggest special:upload could optionally use it. As it stands we have very limitted support for big file upload out of the box, and upwiz does not meet many of the third party use cases.

• Mattflaschen-WMF added a comment.Jul 30 2014, 11:35 PM

See 597142b2e5a0c44b4efd369d1d339e3813aeefdf for a starting point; that doesn't appear to support chunked uploads.

• Mattflaschen-WMF added a comment.Jul 30 2014, 11:35 PM

Just to be clear, that has been merged.

Fomafix added a comment.Jul 31 2014, 10:58 AM

Upload API would also be useful here:
Change-Id: I25a8a8832fab131e026fb062e7c4968193260b07

• Gilles added a project: Multimedia.Nov 24 2014, 3:41 PM
Tgr mentioned this in T91717: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users.Mar 6 2015, 4:06 AM
Jdforrester-WMF added a parent task: T91717: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users.Mar 20 2015, 10:54 PM
• Mattflaschen-WMF renamed this task from Client-side upload API in core to Create mw.Api.plugin.upload for uploading from MediaWiki frontend code.Jun 22 2015, 9:33 PM
• Mattflaschen-WMF merged a task: T103397: Create mw.Api.plugin.upload for uploading from MediaWiki frontend code.
• Mattflaschen-WMF set Security to None.
• Mattflaschen-WMF updated the task description. (Show Details)
• Mattflaschen-WMF added a parent task: T103400: Expand mw.Api.plugin.upload to use chunked uploads when available and selected.
• Mattflaschen-WMF added a parent task: T103399: Expand mw.Api.plugin.upload to stash uploads when requested.
• Mattflaschen-WMF added a parent task: T103398: Expand mw.Api.plugin.upload to use File API where available.
• Mattflaschen-WMF added a subscriber: Aklapper.
MarkTraceur claimed this task.Jun 23 2015, 6:26 PM

I'll start working on this now.

gerritbot subscribed.Jun 24 2015, 7:09 PM

Change 220550 had a related patch set uploaded (by MarkTraceur):
Add frontend API for uploading via iframe

https://gerrit.wikimedia.org/r/220550

gerritbot added a project: Patch-For-Review.Jun 24 2015, 7:09 PM
Jdforrester-WMF closed this task as Resolved.Jul 13 2015, 5:42 PM
Restricted Application added subscribers: Steinsplitter, Matanya. · View Herald TranscriptJul 13 2015, 5:42 PM
Jdforrester-WMF edited projects, added Developer-notice; removed Patch-For-Review.Jul 13 2015, 5:43 PM
gerritbot added a comment.Jul 13 2015, 5:50 PM

Change 220550 merged by jenkins-bot:
Add frontend API for uploading via iframe

https://gerrit.wikimedia.org/r/220550

matmarex mentioned this in rMWc642d2c1a15e: Add frontend API for uploading via iframe.Jul 13 2015, 5:50 PM
• Forrestbot added projects: WMF-deploy-2015-07-14_(1.26wmf14), MW-1.26-release.Jul 13 2015, 6:00 PM
Liuxinyu970226 mentioned this in T56724: Cleanup upload code.Mar 27 2017, 3:38 PM
Aklapper removed subscribers: Anomie, • TrevorParscal, • Mattflaschen-WMF and 2 others.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL