Page MenuHomePhabricator

VisualEditor: Up and down cursor keys don't let you cursor from a focusable node into a slug
Closed, DuplicatePublic0 Estimated Story Points

Description

Intention:
Edit https://www.mediawiki.org/wiki/Sandbox

Steps to Reproduce:

  1. Click on https://www.mediawiki.org/wiki/Sandbox?veaction=edit
  1. Press down arrow key. Nothing happens.
  1. Press up arrow key. Nothing happens.
  1. Huh, how do I get off this template?

Actual Results:
Left and right arrow keys take me to the slugs on either side, so why don't up and down arrow keys do the same?

In my brief testing, this doesn't happen if there is an infobox and text on the page. https://www.mediawiki.org/wiki/Sandbox is the only page that I'm sure it always happens on.

Reproducible: Always


Version: unspecified
Severity: minor
URL: https://www.mediawiki.org/wiki/Sandbox?veaction=edit
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57477

Details

Reference
bz62542

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:01 AM
bzimport set Reference to bz62542.

oliver.buchtala wrote:

It happened that I ran over that issue while debugging. Here some details that may help:

The problem is, that after focussing 've.ce.Surface.onModelSelect()' runs into a case which seems to be dedicated to pasting situations:

...
if ( next ) {
  rangySel = rangy.getSelection( this.getElementDocument() );
  if ( !ve.contains( this.$pasteTarget[0], rangySel.anchorNode, true ) ) {
    ...
  }
...

After that the window selection is on the paste element which will make the next up/down do nothing, but leaving the navigation to the CE.

HTH,

Oliver