Both look identical making development on this feature hard. Let's get this JavaScript code consolidated.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz62543
Event Timeline
Comment Actions
Fixing this bug means deciding what we want to do with the random campaign feature. If we're keeping it, we consolidate the code. If we're not keeping it, we ditch the KeepGoingDrawer and let the KeepGoingOverlay remain relatively simple.
Comment Actions
bingle-admin wrote:
Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1762
Comment Actions
The random feature came out of the fact the KeepGoingDrawer was a generic reusable component, it seems KeepGoingOverlay is less generic now so that's why it isn't using it.
I think regardless of whether we keep the random feature this would be a good exercise for future developments using the keep going overlay (also I think the KeepGoingOverlay name is a bit misleading - KeepGoingOverlayDrawer sounds more descriptive).