Page MenuHomePhabricator
Create Task
Maniphest T64556

Flow: Reply • Edit buttons don't highlight or click
Closed, ResolvedPublic
Actions

Description

The Reply • Edit (and • Thanks) "buttons" for a post don't do anything when you hover and click on them. They should work like the Cancel button.

The fix is to style them mw-ui-button mw-ui-quiet , and then subtract the margins and bolding of mw-ui-quiet. May Galloway calls these "light" buttons, maybe that style should be part of Agora in core. For now either customize .flow-post-interaction .mw-ui-button.mw-ui-quiet , or define a new style {flow/mw}-ui-light.

Also related to bug 62297 (gerrit 113066). When these bugs are fixed the .flow-post-interaction-separator CSS can be updated and simplified.

Version: master
Severity: normal

Details

Reference
bz62556

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:02 AM
• bzimport added a project: StructuredDiscussions.
• bzimport set Reference to bz62556.
• bzimport added a subscriber: Unknown Object (MLST).
• Spage created this task.Mar 12 2014, 12:33 AM
• Spage added a comment.Mar 17 2014, 7:00 PM

I think Reply & Edit should also be mw-ui-progressive (blue on hover/click) and Thank should be mw-ui-constructive (green on hover/click).

Tracked in https://trello.com/c/wBiXSreC
Moving this "light" or "inline" style to core mediawiki.ui is bug 62744.

gerritbot added a comment.Mar 20 2014, 8:02 PM

Change 119812 had a related patch set uploaded by Bencmq:
Apply hover/click highlight to post interaction links

https://gerrit.wikimedia.org/r/119812

gerritbot added a comment.Mar 20 2014, 8:05 PM

Change 119814 had a related patch set uploaded by Bencmq:
Add hover highlight to Thank link in Flow posts

https://gerrit.wikimedia.org/r/119814

gerritbot added a comment.Apr 1 2014, 8:57 PM

Change 119814 merged by jenkins-bot:
Add hover highlight to Thank link in Flow posts

https://gerrit.wikimedia.org/r/119814

gerritbot added a comment.Apr 1 2014, 8:59 PM

Change 119812 merged by jenkins-bot:
Reorganise flow-post-interaction link styling

https://gerrit.wikimedia.org/r/119812

Quiddity removed a subscriber: Maryana.Dec 19 2014, 1:39 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL