Page MenuHomePhabricator

URL generated by {{fullurl:}} does not include mobile domain prefix
Closed, ResolvedPublic

Description

Intention:
Visiting upload page on mobile

Steps to Reproduce:

  1. Log in
  2. go to https://commons.m.wikimedia.org/wiki/Special:Upload
  3. Click

Actual Results:
Link takes you to https://commons.wikimedia.org/w/index.php?title=Special:UserLogin

Expected Results:
Link should take you to https://commons.m.wikimedia.org/w/index.php?title=Special:UserLogin

Reproducible: Always

Work around is simply to use the menu but it's still counter intuitive compared to the obvious "Log in" link.


Version: unspecified
Severity: minor

Details

Reference
bz62640

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:50 AM
bzimport set Reference to bz62640.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1774

I'm not sure what you mean by your steps
Do you mean...?

  1. Go to the mobile site of Special:Upload on https://commons.m.wikimedia.org/wiki/Special:Upload
  2. Where it says "You must be logged in to upload files." click the login link.

Actual:
You are now on the desktop page of the login form

Expected:
You should be on the mobile page of the login form

If so this is actually not a bug in MobileFrontend. Note that this works fine on http://en.m.wikipedia.org/wiki/Special:Upload so I suspect this may even be a issue on the wiki itself since the message that appears is different.

On commons the link is an external one rather than a local link, this looks broken.

This is either

  • a bug in core
  • Some other extension live on Commons
  • A configuration issue on Commons

The text comes from [[commons:MediaWiki:Uploadnologintext]] which has been customized (normally the upload link would be a parameter - see https://commons.m.wikimedia.org/wiki/Special:Upload?uselang=qqx which works as expected).

So the root issue is that {{fullurl}} does not respect the current domain. (Although I'm not sure why they even use it when $1 gives the same link but also keeps any query parameters. Might be a legacy thing.)

Test case: https://m.mediawiki.org/wiki/User:Tgr_(WMF)/test/fullurl

Putting back tentatively to MobileFrontend although in the end it might be some sort of site config issue; I'm not familiar with how the mobile domains are set up.

  • This bug has been marked as a duplicate of bug 50399 ***

Asked for a local fix on Commons: https://commons.wikimedia.org/wiki/MediaWiki_talk:Uploadnologintext#Use_.241_for_link

Seems like the message is in a similar or worse shape on other wikis as well; not sure what would be the right place to raise awareness of that (translators-l?)