Page MenuHomePhabricator

do snack validation in changeop
Closed, ResolvedPublic

Description

Snack validation should be triggered via the respective changeops. This will reduce code duplication. Make sure that we only validate when a snack actually changes.


Version: master
Severity: normal
Whiteboard: u=dev c=backend p=5 s=2014-04-01
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=62643

Details

Reference
bz62644

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:50 AM
bzimport set Reference to bz62644.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 63114 has been marked as a duplicate of this bug. ***

Change 123860 had a related patch set uploaded by Daniel Kinzler:
(bug 62644) snak validation in ChangeOpMainSnak.

https://gerrit.wikimedia.org/r/123860

Change 123872 had a related patch set uploaded by Daniel Kinzler:
(bug 62644) snak validation in ChangeOpReference

https://gerrit.wikimedia.org/r/123872

Change 124317 had a related patch set uploaded by Daniel Kinzler:
(bug 62644) No snak val in ClaimModificationHelper

https://gerrit.wikimedia.org/r/124317

Change 121689 merged by jenkins-bot:
(bug 62644) Move Snak validation into ChangeOps

https://gerrit.wikimedia.org/r/121689

Change 123860 merged by jenkins-bot:
(bug 62644) snak validation in ChangeOpMainSnak.

https://gerrit.wikimedia.org/r/123860

Change 123872 merged by jenkins-bot:
(bug 62644) Snak validation in more ChangeOps

https://gerrit.wikimedia.org/r/123872

Change 124317 merged by jenkins-bot:
(bug 62644) No snak val in ClaimModificationHelper

https://gerrit.wikimedia.org/r/124317