Page MenuHomePhabricator
Create Task
Maniphest T64681

VisualEditor: The image highlight box is not getting redrawn properly while changing image type to thumbnail/frame
Closed, ResolvedPublic
Actions

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Add a caption to it
3.Save the page
4.Reopen the page
5.Go to the Media Settings of that image and change the image type to thumbnail/frame

Observed Result:
The image highlight box does not appear properly, caption also gets missing

See the screenshot attached

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:https://test2.wikipedia.org/wiki/14thmarchwmf18

Try the image in this page

Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=64563

Attached:

Screen_Shot_2014-03-14_at_5.05.57_PM.png (494×1 px, 115 KB)

Details

Reference
bz62681

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:53 AM
• bzimport added a project: VisualEditor-ContentEditable.
• bzimport set Reference to bz62681.
Ryasmeen created this task.Mar 15 2014, 12:07 AM
Ryasmeen added a comment.May 5 2014, 7:26 PM

Created attachment 15299
Screenshot april 5th

Attached:

Screen_Shot_2014-05-05_at_12.24.46_PM.png (486×1 px, 264 KB)

Ryasmeen added a comment.May 16 2014, 12:21 AM

This issue did not get resolved with new image model.

gerritbot added a comment.Jun 16 2014, 12:49 PM

Change 137040 had a related patch set uploaded by Esanders:
[BREAKING CHANGE (ish)] Track orignal data position in insertion operations

https://gerrit.wikimedia.org/r/137040

Esanders added a comment.Jun 16 2014, 12:50 PM

Issue is with dm selection, not shields/highlights.

Esanders added a comment.Jun 16 2014, 12:52 PM

Edited wrong bug, ignore change 137040 and above comment.

Jdforrester-WMF added a comment.Jul 8 2014, 8:25 PM

This now appears to be working fine?

Ryasmeen added a comment.Jul 8 2014, 10:57 PM

Created attachment 15871
Screenshot

Making an image frame-right or frame-left makes the highlight of the image too big to go beyond the CE, not sure if this should be tagged with this bag or not.

See the screenshot attached

Attached:

Screen_Shot_2014-07-08_at_3.56.39_PM.png (454×1 px, 351 KB)

Ryasmeen added a comment.Jul 8 2014, 10:57 PM

bug* not bag :|

Jdforrester-WMF added a comment.Jul 9 2014, 12:01 AM

(In reply to ryasmeen from comment #7)

Created attachment 15871 [details]
Screenshot

Making an image frame-right or frame-left makes the highlight of the image
too big to go beyond the CE, not sure if this should be tagged with this bug
or not.

See the screenshot attached

I think that's a distinct issue. :-(

Attached:

Screen_Shot_2014-07-08_at_3.56.39_PM.png (454×1 px, 351 KB)

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:01 AM
Jdforrester-WMF removed a parent task: T39870: VisualEditor: Support media (tracking).Feb 25 2015, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL