Page MenuHomePhabricator

Flow: remove "title" element from textarea boxes
Closed, ResolvedPublic

Description

screenshot

Currently, the "reply" textarea boxes in flow have a "title=" element that matches the "placeholder=" content. eg. "Reply to 137.147.205.98"

This results in a tooltip appearing whenever I move the mouse cursor within the textarea, which is annoying.

(It's also using the wrong name in some circumstances, eg the example attached, so that's another good reason to remove it! Less things to keep accurate)


Version: unspecified
Severity: normal
URL: https://www.mediawiki.org/w/index.php?title=Talk:Flow&topic_postId=rqhdbepux60pvsf3&workflow=rqhdbepux60pvsf3

Attached:

Screenshot_from_2014-03-14_17:28:00.png (1×1 px, 137 KB)

Details

Reference
bz62683

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:53 AM
bzimport set Reference to bz62683.
bzimport added a subscriber: Unknown Object (MLST).

Hmm, it concerns me that the tooltip has the wrong username; makes me worry that we're not storing that info properly, and it's important that we do...

Hmm, I can't reproduce the incorrect placeholder text in the tooltip on ee-flow, so this isn't as concerning to me... if you see it happening again, let me know!

(In reply to Maryana Pinchuk from comment #2)

Hmm, I can't reproduce the incorrect placeholder text in the tooltip on
ee-flow, so this isn't as concerning to me... if you see it happening again,
let me know!

Seems to be a 3rd-level indent problem? eg this post:
http://ee-flow.wmflabs.org/w/index.php?title=Talk:Flow_Team_Retrospective&topic_postId=rqike6z2610xg1f0&workflow=rqijnthfwtsf26gc#flow-post-rqike6z2610xg1f0
and this one: http://ee-flow.wmflabs.org/w/index.php?title=Talk:Flow_Team_Retrospective&topic_postId=rqipo2by26kk22b0&workflow=rqijn7scmxk6992k#flow-post-rqipo2by26kk22b0

The wrong username being shown on the title is no "real issue". Because deepest-level replies can't have other replies, we re-use the parent level's reply textareas (which is where the reply will be added to)

We only change the content to: Reply to <the real username you wanted to reply to>

Since we'll be removing the title attribute altogether, we won't have to fix that text :p