Page MenuHomePhabricator
Create Task
Maniphest T64709

Images in galleries should have srcset (category pages, <gallery/> tag)
Closed, ResolvedPublic
Actions

Description

Same like in thumbnails, see https://dev.w3.org/html5/srcset

Example: https://commons.wikimedia.org/wiki/Category:Magnetic_resonance_imaging_of_the_brain

Details

Reference
bz62709
SubjectRepoBranchLines +/-
Update parser test case for gallery srcset supportmediawiki/extensions/Citemaster+1 -1
Add srcset for images in <gallery>mediawiki/coremaster+20 -18
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:54 AM
• bzimport added a project: MediaWiki-Categories.
• bzimport set Reference to bz62709.
• bzimport added a subscriber: Unknown Object (MLST).
Rezonansowy created this task.Mar 16 2014, 2:43 PM
Aklapper added a comment.Mar 17 2014, 10:10 AM

Elaborating why they "should" have a srcset welcome.
What is broken if they don't have? Is srcset new in HTML5?

Rezonansowy added a comment.Mar 17 2014, 11:52 AM

(In reply to Andre Klapper from comment #1)

Elaborating why they "should" have a srcset welcome.
What is broken if they don't have? Is srcset new in HTML5?

Yes it is new in HTML5 and already implement on MediaWiki thumbnails. We need it for same reasons as we needed in thumbnails. There are many bugs with srcset - https://bugzilla.wikimedia.org/buglist.cgi?quicksearch=srcset&list_id=287414.

matmarex renamed this task from Images on categories should have srcset to Images in galleries should have srcset (category pages, <gallery/> tag).Feb 23 2015, 5:47 PM
matmarex updated the task description. (Show Details)
matmarex added projects: MediaWiki-User-Interface, Multimedia.
matmarex set Security to None.
matmarex removed a subscriber: Unknown Object (MLST).
matmarex subscribed.

This issue also affects other places where galleries are rendered, using the <gallery/> tag.

gerritbot subscribed.Feb 25 2015, 10:15 PM

Change 192960 had a related patch set uploaded (by Brian Wolff):
Add srcset for images in <gallery>

https://gerrit.wikimedia.org/r/192960

gerritbot added a project: Patch-For-Review.Feb 25 2015, 10:15 PM
gerritbot added a comment.Feb 26 2015, 5:22 PM

Change 192960 merged by jenkins-bot:
Add srcset for images in <gallery>

https://gerrit.wikimedia.org/r/192960

Bawolff mentioned this in rMW06c9f3ae7fb9: Add srcset for images in <gallery>.Feb 26 2015, 5:22 PM
gerritbot added a comment.Feb 26 2015, 5:59 PM

Change 193146 had a related patch set uploaded (by Brion VIBBER):
Update parser test case for gallery srcset support

https://gerrit.wikimedia.org/r/193146

matmarex closed this task as Resolved.Feb 26 2015, 6:47 PM
matmarex assigned this task to Bawolff.
matmarex removed a project: Patch-For-Review.
matmarex removed a subscriber: gerritbot.

Well, that was sudden! :D

gerritbot added a comment.Feb 26 2015, 7:01 PM

Change 193146 merged by jenkins-bot:
Update parser test case for gallery srcset support

https://gerrit.wikimedia.org/r/193146

• brion mentioned this in rECIT931707fd4ae5: Update parser test case for gallery srcset support.Feb 26 2015, 7:03 PM
Ricordisamoa awarded a token.Mar 1 2015, 7:39 AM
Ricordisamoa subscribed.
• brion mentioned this in rMEXTf19223c97dd9: Updated mediawiki/extensions Project: mediawiki/extensions/Cite….Mar 11 2015, 6:27 AM
Aklapper added a project: HTML5.May 17 2021, 11:52 AM
Aklapper removed a parent task: T21719: [DO NOT USE] HTML5 features (tracking) [superseded by #HTML5].May 17 2021, 11:57 AM
Bugreporter removed a parent task: T34101: High-density display issues (HiDPI) (tracking).Aug 20 2021, 7:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL