When $wgDebugToolbar is true, all users can access to debug toolbar now. But maybe someone want to show debug toolbar to specific users, not to all users. So can hide internal infomation to normal users.
Version: 1.23.0
Severity: enhancement
URL: https://www.mediawiki.org/wiki/Requests_for_comment/Debugging_at_production_server
Hmmm. I suppose it wouldn't hurt to bind this feature to a MediaWiki user right. And perhaps even give this user right only to sysops by default. Maybe. This needs further consideration.
Change 119002 had a related patch set uploaded by devunt:
Make only allowed user can use debug toolbar
+ !
I'm not sure how much discussion we still need. For a smooth transition, I'd say: if the toolbar is enabled, show it to all users by default (current situation) and offer a config setting to tie its visibility to specific user rights.
Debug toolbar on the production environment is usually needed when doing some sort of troubleshooting. And not surprisingly, it is usually used by server administrator, who is capable of editing server settings.
Consider these two scenarios:
I prefer method #1, which is current implementation.
It makes sense to restrict the envisaged 'usedebugtoolbar' permission to sysops or bureaucrats by default. It would be a breaking change so that's why I made the suggestion but I'm fine with either approach.
Method 2 does not seem right to me. By "current implementation" I suppose you mean current best practice?
@devunt: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assignee avoids the impression that somebody is already working on this task. It also allows others to potentially work towards fixing this task. Please claim this task again when you plan to work on it (via Add Action... → Assign / Claim in the dropdown menu) - it would be welcome. Thanks for your understanding!