Log entries generated by extensions that are later removed should still show title
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Withoutaname
	Mar 17 2014, 10:19 AM

Description

Example case, user Phoenix7777 "Changed visibility of the article feedback tool on [[Senkaku Islands]]" article, which has autoconfirmed edit protection and sysop move protection, causing this malformed entry to appear in https://en.wikipedia.org/w/index.php?title=Special:Log&page=Senkaku+Islands

02:47, 6 February 2014 Phoenix7777 (talk | contribs) protect

URL: https://en.wikipedia.org/w/index.php?title=Senkaku_Islands&diff=594189587
See Also: T60039: "Changed visibility of the article feedback tool" entry in public log

Details

Reference: bz62722

	Subject	Repo	Branch	Lines +/-
	Show title for unknown log actions	mediawiki/core	master	+31 -17

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		BrandonXLF	T64722 Log entries generated by extensions that are later removed should still show title
		Open		None	T115303 Expunge old AFTv5 log entries on WMF wikis

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:55 AM

• bzimport added a project: MediaWiki-Logevents.

• bzimport set Reference to bz62722.

• bzimport added a subscriber: Unknown Object (MLST).

Withoutaname created this task.Mar 17 2014, 10:19 AM

The log entries looked fine when AFT5 was still deployed. They look odd now because it was removed, so there's really nothing that can be fixed in the extension at this point. The core logging code may be fixable.

I think the log_title could be incorporated somehow.

MariaDB [enwiki_p]> SELECT * FROM logging WHERE log_id=54663738 \G

1. row ******* log_id: 54663738 log_type: articlefeedbackv5 log_action: protect

log_timestamp: 20140206104723

log_user: 10001499

log_namespace: 0

  log_title: Senkaku_Islands
log_comment: 
 log_params: a:2:{s:10:"permission";s:10:"aft-reader";s:6:"expiry";s:8:"infinity";}
log_deleted: 0

log_user_text: Phoenix7777

log_page: 348333

writ.keeper.enwp wrote:

More examples (from https://en.wikipedia.org/w/index.php?title=Special:Log&user=Grfr12345):

09:02, 7 December 2013 Grfr12345 (talk | contribs | block) noaction
09:02, 7 December 2013 Grfr12345 (talk | contribs | block) create

(In reply to writ.keeper.enwp from comment #3)

More examples (from
https://en.wikipedia.org/w/index.php?title=Special:Log&user=Grfr12345):

09:02, 7 December 2013 Grfr12345 (talk | contribs | block) noaction
09:02, 7 December 2013 Grfr12345 (talk | contribs | block) create

https://en.wikipedia.org/w/api.php?action=query&list=logevents&letitle=Special:ArticleFeedbackv5/E-class+Melbourne+tram/050b312c0a45662828ca90b11c28d444&format=jsonfm

DerHexer merged a task: T107533: Broken articlefeedbackv5 log actions.Jul 30 2015, 11:58 PM

DerHexer added subscribers: hoo, DerHexer, Aklapper.

Krenair renamed this task from Log entries generated by extensions that are later removed appear malformed to Log entries generated by extensions that are later removed should still show title.Aug 1 2015, 10:43 PM

Krenair set Security to None.

Krenair subscribed.

Couple of things here:

(1) The core fallback logging code could really be improved. It could print something like
User (talk | contribs) performed unknown action "..." on [[Main Page]] ($4, $5, ...)
Not sure about old vs. new log entry styles though...

(2) Even though AFTv5 has been uninstalled from enwiki, the log formatter should still be provided. I think this can be done through the WikimediaMessages extension. I'll file a task for that.

Aklapper mentioned this in T115303: Expunge old AFTv5 log entries on WMF wikis.Oct 13 2015, 8:50 AM

MarcoAurelio updated the task description. (Show Details)Aug 1 2016, 11:12 AM

MarcoAurelio removed a subscriber: • wikibugs-l-list.

MarcoAurelio subscribed.

TTO merged a task: T126123: Logs of removed extensions appear in logs unformatted.Aug 12 2016, 9:44 AM

TTO added subscribers: Cenarium, • MZMcBride, Nemo_bis, gerritbot.

This is also a problem for the removed EducationProgram extension e.g. https://en.wikipedia.org/wiki/Special:Log/Larson.309

Change 746005 had a related patch set uploaded (by BrandonXLF; author: BrandonXLF):

[mediawiki/core@master] Show title for unknown log actions

https://gerrit.wikimedia.org/r/746005

gerritbot added a project: Patch-For-Review.Dec 12 2021, 7:34 AM

BrandonXLF subscribed.Dec 12 2021, 7:48 AM

BrandonXLF added a project: Growth-Team.Sep 11 2022, 4:03 AM

matej_suchanek updated the task description. (Show Details)Sep 11 2022, 3:20 PM

@BrandonXLF this task/patch isn't something our team is able to focus on right now. Maybe looking at git blame on LogPage.php would help you find some recent committers/reviewers to this file; https://www.mediawiki.org/wiki/Developers/Maintainers also indicates that @Umherirrender may be interested in this.