Page MenuHomePhabricator

VisualEditor: Its possible to input a fraction value (with decimal point) in image size which results into showing wrong size in the review changes section
Closed, ResolvedPublic

Description

Setting decimal value

Steps to reproduce:

1.Open a page with VE
2.Insert a new image
3.Set the image size to a long value which becomes a number with scientific notation
4.Now start deleting the value from right to left
5.Once you have deleted the scientific notation (e) and the number becomes a value with decimal point , click on "Apply Changes"

Observed Issue 1: it accepts that decimal value

6.Click on Save Page and go to "Review your Changes"

Observed Issue 2: The size value showing in the review changes section are completely different that what was set in step 5

See the screenshots attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/w/index.php?title=17marchff&veaction=edit


Version: unspecified
Severity: minor

Attached:

Screen_Shot_2014-03-17_at_3.23.57_PM.png (487×922 px, 59 KB)

Details

Reference
bz62756

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:57 AM
bzimport set Reference to bz62756.

Created attachment 14843
The discrepancy in review changes section

Attached:

Screen_Shot_2014-03-17_at_3.23.49_PM.png (467×906 px, 48 KB)

This doesn't happen anymore with the new MediaSizeWidget and the DimensionsWidget; they don't allow for decimal values at all.

Verified the fix in production