Page MenuHomePhabricator
Create Task
Maniphest T64798

[Task] Consolidate watchlist and recent changes hook query code in Wikibase Client
Closed, ResolvedPublic
Actions

Description

The wikibase code that handles watchlist query was written when:

  1. options were not exposed to the hook
  2. were arrays instead of objects.
  3. SpecialRecentChangesFilters and SpecialWatchlistFilters hooks were used instead of ChangesListSpecialPageFilters (see I9cceda5d2dcf)
  4. SpecialRecentChangesQuery and SpecialWatchlistQuery hooks were used instead of ChangesListSpecialPageQuery (see I9cceda5d2dcf)

We should change from the old hooks that needed separate handling for Watchlist and RC to the new generic hooks.

We can also now make use of FormOptions, which would allow us to hook in more cleanly.

Details

Reference
bz62798
SubjectRepoBranchLines +/-
Consolidate watchlist / recent changes query hook handlingmediawiki/extensions/Wikibasemaster+395 -702
Consolidate watchlist / recent changes query hook handling [WIP]mediawiki/extensions/Wikibasemaster+259 -425
Switch to use ChangesListSpecialPageFilters hook in clientmediawiki/extensions/Wikibasemaster+395 -299
Customize query in gerrit

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:00 AM
• bzimport added a project: MediaWiki-extensions-WikibaseClient.
• bzimport set Reference to bz62798.
• bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Mar 18 2014, 6:30 PM
aude added a comment.Mar 20 2014, 11:49 AM

perhaps we can even find a way to abstract / improve handling of these queries more generally.

it's a bit icky the way we modify the queries.

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 3:00 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher raised the priority of this task from Low to High.Oct 13 2015, 12:11 PM

Setting to high in hopes that this will help us with enhanced recent changes support

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2015, 12:11 PM
Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.Oct 13 2015, 12:12 PM
• Jonas renamed this task from Consolidate watchlist and recent changes hook query code in Wikibase Client to [Task] Consolidate watchlist and recent changes hook query code in Wikibase Client.Nov 2 2015, 11:44 AM
• Jonas updated the task description. (Show Details)
• Jonas set Security to None.
Lydia_Pintscher added a project: Wikidata-Sprint-2015-11-03.Nov 2 2015, 2:37 PM
Tobi_WMDE_SW lowered the priority of this task from High to Medium.Nov 3 2015, 2:29 PM
daniel updated the task description. (Show Details)Nov 3 2015, 3:04 PM
daniel subscribed.

I have updated the description of this task to reflect the fact that core now offers hooks that can be used to modify the behavior of Watchlist and RecentChanges consistently. There is no more need to share code between the handlers for Watchlist and RecentChanges, because it will now be the same handler.

gerritbot subscribed.Nov 10 2015, 6:19 AM

Change 252162 had a related patch set uploaded (by Aude):
Switch to use ChangesListSpecialPageFilters hook in client

https://gerrit.wikimedia.org/r/252162

gerritbot added a project: Patch-For-Review.Nov 10 2015, 6:19 AM
Lydia_Pintscher added a comment.Nov 10 2015, 1:08 PM

Next steps:

  • investigate current situation for enhanced recent changes after the switch of these hooks
Lydia_Pintscher moved this task from Proposed to Review on the Wikidata-Sprint-2015-11-03 board.Nov 10 2015, 1:09 PM
aude claimed this task.Nov 11 2015, 9:34 PM
gerritbot added a comment.Nov 12 2015, 12:56 PM

Change 252162 merged by jenkins-bot:
Switch to use ChangesListSpecialPageFilters hook in client

https://gerrit.wikimedia.org/r/252162

JanZerebecki moved this task from Review to Done on the Wikidata-Sprint-2015-11-03 board.Nov 12 2015, 4:57 PM
aude added a comment.Nov 12 2015, 5:04 PM

maybe I should have made subtasks for this, but https://gerrit.wikimedia.org/r/#/c/252173/ (part 2) of this is still in doing...

Sjoerddebruin subscribed.Nov 12 2015, 5:10 PM
Lydia_Pintscher moved this task from consider for next sprint to in progress on the Wikidata board.Nov 13 2015, 2:24 PM
Tobi_WMDE_SW moved this task from Done to Doing on the Wikidata-Sprint-2015-11-03 board.Nov 16 2015, 11:18 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-11-17.Nov 17 2015, 12:40 PM
Tobi_WMDE_SW moved this task from Proposed to Doing on the Wikidata-Sprint-2015-11-17 board.
matej_suchanek added a parent task: T46874: [Epic] Full support for wikibase edits in enhanced changes format ("Group changes by page in recent changes and watchlist" [usenewrc]).Nov 18 2015, 3:33 PM
gerritbot added a comment.Nov 22 2015, 12:37 PM

Change 254681 had a related patch set uploaded (by Aude):
Consolidate watchlist / recent changes query hook handling

https://gerrit.wikimedia.org/r/254681

gerritbot added a comment.Nov 23 2015, 2:22 AM

Change 252173 abandoned by Aude:
Consolidate watchlist / recent changes query hook handling [WIP]

Reason:
see Ib660a01 instead

https://gerrit.wikimedia.org/r/252173

aude moved this task from Doing to Review on the Wikidata-Sprint-2015-11-17 board.Nov 24 2015, 8:04 PM
JanZerebecki mentioned this in T119640: use rc_source instead of rc_type to filter out wikidata recent changes.Nov 25 2015, 5:54 PM
gerritbot added a comment.Nov 25 2015, 6:36 PM

Change 254681 merged by jenkins-bot:
Consolidate watchlist / recent changes query hook handling

https://gerrit.wikimedia.org/r/254681

daniel closed this task as Resolved.Nov 25 2015, 6:47 PM
daniel moved this task from Review to Done on the Wikidata-Sprint-2015-11-17 board.
matej_suchanek updated the task description. (Show Details)Nov 25 2015, 6:57 PM
matej_suchanek removed a project: Patch-For-Review.
matej_suchanek removed subscribers: gerritbot, Wikidata-bugs.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL