Page MenuHomePhabricator
Create Task
Maniphest T64812

VisualEditor: setResizableHandlesSizeAndPosition() shouldn't measure things on every keypress
Closed, ResolvedPublic
Actions

Description

In afterDocumentKeyPress, setResizableHandlesSizeAndPosition() is called and measures and repositions all ResizableNode resize handles, even though they're not even visible. This is wasteful.

Version: unspecified
Severity: enhancement

Details

Reference
bz62812

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:01 AM
• bzimport added projects: VE-deploy-2014-07-24, VisualEditor-ContentEditable, Performance Issue.
• bzimport set Reference to bz62812.
Catrope created this task.Mar 19 2014, 12:26 AM
Catrope added a comment.Oct 6 2014, 9:48 AM

This was fixed at some point. setResizableHandlesSizeAndPosition() is now attached to the 'position' event on focus and detached on blur.

Jdforrester-WMF added a comment.Oct 6 2014, 3:52 PM

Fixed in gerrit Ia6cf8de0da0.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 1:48 AM
bd808 moved this task from Tag to Archive on the Performance Issue board.Mar 11 2015, 7:30 PM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL