It was already installed on tools but due to the migration it's not there
It's a pretty necessary package for software development [1]
[1]: http://www.mediawiki.org/wiki/Gerrit/git-review
Best
Version: unspecified
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz62871
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Dzahn | T257496 toolforge needs git-review 1.27+ to work with new Gerrit deploy | |||
| Resolved | scfc | T64871 Install git review on tools |
Event Timeline
Comment Actions
Change 118595 had a related patch set uploaded by Tim Landscheidt:
Tools: Install packages git-review and joe
Comment Actions
I need gerrit review in exec_environment (in order to be able to use it while using jsub)
Comment Actions
It is already included in exec_environ (cf. http://git.wikimedia.org/blob/operations%2Fpuppet.git/production/modules%2Ftoollabs%2Fmanifests%2Fexec_environ.pp#L283) and, indeed, it is installed on all exec nodes:
| [tim@passepartout ~]$ pdsh -f 1 -w tools-exec-0[1-9].eqiad.wmflabs -w tools-exec-1[0-3].eqiad.wmflabs 'if dpkg-query -s git-review > /dev/null 2>&1; then echo Installed.; else echo Not installed.; fi' |
| tools-exec-01: Installed. |
| tools-exec-02: Installed. |
| tools-exec-03: Installed. |
| tools-exec-04: Installed. |
| tools-exec-05: Installed. |
| tools-exec-06: Installed. |
| tools-exec-07: Installed. |
| tools-exec-08: Installed. |
| tools-exec-09: Installed. |
| tools-exec-10: Installed. |
| tools-exec-11: Installed. |
| tools-exec-12: Installed. |
| tools-exec-13: Installed. |
| [tim@passepartout ~]$ |
I've had a look at your scripts and unfortunately they're too complicated to make a quick assessment why "git review" is failing. I do note however that you are trying to execute it from within Python via subprocess.Popen(), so I added a debug print of $PATH to maintenance1.py and maintenance4.py. Please ping me in Cloud-Services when you get another failure.