Page MenuHomePhabricator
Create Task
Maniphest T64878

jquery.makeCollapsible does not handle thead and tfoot as used by jquery.tablesorter
Closed, ResolvedPublic
Actions

Description

Example of issue: [https://en.wikipedia.org/w/index.php?title=User:Mdowdell/sandbox&oldid=600478437]

As can be seen in [https://en.wikipedia.org/w/index.php?title=User:Mdowdell/sandbox&oldid=600478437#mw-collapsible_mw-collapsed_sortable] the mw-collapsed sortable table hides the second row used for sorting. However, the collapsible table [https://en.wikipedia.org/w/index.php?title=User:Mdowdell/sandbox&oldid=600478437#collapsble_collapsed_sortable] show the second row when uncollapsing the table.

The problem is that mw-collapsible does not account for table rows placed in thead and tfoot, which are used by tablesorter.
It has the selector

$collapsible.find( '> tbody > tr' );

Version: 1.23.0
Severity: normal

Details

Reference
bz62878
SubjectRepoBranchLines +/-
mediawiki.page.ready: Simpler tablesorter/makeCollapsible callmediawiki/coremaster+8 -13
Run tablesorter before makeCollapsiblemediawiki/coremaster+22 -11
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:06 AM
• bzimport added a project: MediaWiki-JavaScript.
• bzimport set Reference to bz62878.
• bzimport added a subscriber: Unknown Object (MLST).
onei created this task.Mar 20 2014, 5:44 PM
onei added a comment.Mar 21 2014, 12:11 AM

I've fixed this bug for Wikia, although jquery.makeCollapsible is different between 1.19 and the current release. The fix for 1.19 can be seen at https://github.com/Wikia/app/pull/2675/files

With the changes made in Bug 30352, this is just a matter of removing the conditional at http://git.wikimedia.org/blob/mediawiki%2Fcore.git/master/resources%2Fjquery%2Fjquery.makeCollapsible.js#L63 and always select every row. The row with the toggle should be excluded in the next conditional on L68.

I'd like to fix this myself if possible, I'm just a little unsure of how to do so with gerrit so it might take a little while for me to get around to submitting a patch.

matmarex added a comment.Mar 21 2014, 12:59 AM

Thanks for the report!

Here's a quickstart Gerrit guide:
https://www.mediawiki.org/wiki/Gerrit/Getting_started

Here's a detailed, extremely boring one:
https://www.mediawiki.org/wiki/Gerrit/Tutorial

And if you can't get it to work, there's a service that lets you directly upload patches in standard formats: http://tools.wmflabs.org/gerrit-patch-uploader/

matmarex edited projects, added MediaWiki-User-Interface, JavaScript; removed MediaWiki-JavaScript.Dec 21 2014, 5:36 PM
Aklapper added a project: MediaWiki-jQuery-Tablesorter--archived.Feb 12 2015, 4:36 PM
TheDJ renamed this task from jquery.makeCollapsible incompatible with jquery.tablesorter to jquery.makeCollapsible does not handle thead and tfoot as used by jquery.tablesorter.Dec 21 2015, 4:13 PM
TheDJ merged a task: T68948: Class "sortable" does not work with "mw-collapsible mw-collapsed" in some tables..
TheDJ updated the task description. (Show Details)
TheDJ set Security to None.
TheDJ added subscribers: TheDJ, Aklapper, Lejonel.
• Phabricator_maintenance removed a subscriber: • wikibugs-l-list.Jul 30 2016, 3:45 PM
• Phabricator_maintenance removed a parent task: T33601: [DO NOT USE] jquery-tablesorter (tracking) [superseded by #MediaWiki-jQuery-Tablesorter].Jul 30 2016, 3:45 PM
Volker_E merged a task: T114607: jQuery.makeCollapsible not compatible with jquery.tablesorter.Sep 17 2019, 4:51 AM
Volker_E added subscribers: Cblair91, MatthiasDD, gerritbot.
Volker_E mentioned this in T196925: Collapsing a table makes it disappear (jquery.makeCollapsible).Sep 17 2019, 4:53 AM
TheDJ merged a task: T247713: Sortable, collapsible and collapsed tables with two-row headers hide the subheader row.Mar 16 2020, 5:14 PM
TheDJ added subscribers: Zarex, RhinosF1.
Krinkle unsubscribed.Mar 16 2020, 9:17 PM
TheDJ merged a task: T248645: If a wikitable with classes "sortable mw-collapsible mw-collapsed" has multiple header rows, only the first one shows up..Mar 27 2020, 12:39 PM
TheDJ added a subscriber: JochemvanHees.
matmarex claimed this task.Apr 6 2020, 8:21 PM

I looked at this again. At first I was very confused because I couldn't reproduce the problem. Then I realized that it depends on the order in which the two scripts run – sortable-then-collapsible is good; collapsible-then-sortable is bad. (This is because jquery.makeCollapsible can actually handle thead and tfoot, but it can't handle it when they are inserted after it was already initialized on a table.) Conveniently, that makes the bug easy to fix!

gerritbot added a comment.Apr 6 2020, 8:22 PM

Change 586436 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Run tablesorter before makeCollapsible

https://gerrit.wikimedia.org/r/586436

gerritbot added a project: Patch-For-Review.Apr 6 2020, 8:22 PM
gerritbot added a comment.Apr 7 2020, 9:39 AM

Change 586436 merged by jenkins-bot:
[mediawiki/core@master] Run tablesorter before makeCollapsible

https://gerrit.wikimedia.org/r/586436

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.27; 2020-04-07).Apr 7 2020, 10:00 AM
TheDJ added a comment.Apr 7 2020, 10:02 AM

i'm not sure if this fixes all problems, but it should fix at least 95% of them.

TheDJ closed this task as Resolved.Apr 7 2020, 1:09 PM
TheDJ removed a project: Patch-For-Review.

Provisionally closing. Please open a new ticket if you find new cases after this gets deployed next week.

Krinkle awarded a token.Apr 13 2020, 3:49 PM
gerritbot added a comment.Aug 12 2020, 2:04 AM

Change 619601 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.page.ready: Simpler tablesorter/makeCollapsible call

https://gerrit.wikimedia.org/r/619601

gerritbot added a project: Patch-For-Review.Aug 12 2020, 2:04 AM
gerritbot added a comment.Aug 17 2020, 8:58 PM

Change 619601 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.page.ready: Simpler tablesorter/makeCollapsible call

https://gerrit.wikimedia.org/r/619601

matmarex mentioned this in T265134: "wikitable sortable mw-collapsible mw-collapsed" is no longer displaying sortable headings when there are two tr lines with th elements.Oct 9 2020, 3:35 PM
matmarex mentioned this in T260642: Regression: Collapsible forms stopped working on Mobile special page.Oct 20 2020, 4:55 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL