Use alternative separator character when calling wbparsevalue
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	daniel
	Mar 21 2014, 2:38 PM

Description

wbparsevalue accepts multiple strings to parse in one request. These are passed as a pipe-separated list via the values parameter. This means that any client code, including the Wikibase UI code, needs to use the alternative separator character:

The API offers an alternative separator for multivalue parameters: If a string starts with ASCII code \x1F (Unit Separator), any other occurrence of \x1F in the string will be treated as a separator, and pipe characters are treated as literal. See ApiBase::explodeMultiValue() for reference.

Clients that want to allow pipe characters to be present in aliases need to prepend the parameter value with \x1F.

See also T167785: Use alternative separator character when calling wbsetaliases

Patch-For-Review:

Details

Reference: bz62925

	Subject	Repo	Branch	Lines +/-
	Update JavaScript API dependency to 2.2.2	mediawiki/extensions/Wikibase	master	+1 -1
	Use alternative separator character in API requests	mediawiki/extensions/WikibaseJavaScriptApi	master	+65 -52

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Greta_Doci_WMDE	T167226 All text after a pipe character is silently removed when saving a monolingual text property
		Resolved		thiemowmde	T64925 Use alternative separator character when calling wbparsevalue

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:51 AM

• bzimport added a project: MediaWiki-extensions-WikibaseRepository.

• bzimport set Reference to bz62925.

• bzimport added a subscriber: Unknown Object (MLST).

daniel created this task.Mar 21 2014, 2:38 PM

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 2:46 PM

Lydia_Pintscher removed a subscriber: Unknown Object (MLST).

Ricordisamoa renamed this task from wbparsevalue cannot process strings that contain a pipe "|" caharcter to wbparsevalue cannot process strings that contain a pipe "|" character.Sep 5 2015, 1:58 AM

Ricordisamoa set Security to None.

Ricordisamoa subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 5 2015, 1:58 AM

@daniel Can we consider this fixed, with https://lists.wikimedia.org/pipermail/mediawiki-api-announce/2016-August/000117.html?

matej_suchanek added a project: TestMe.Feb 22 2017, 8:58 PM

matej_suchanek updated the task description. (Show Details)

matej_suchanek removed a subscriber: Wikidata-bugs.

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptFeb 22 2017, 8:58 PM

matej_suchanek merged a task: T135397: [Bug] Parsevalue API doesn't work with pipes in values.Apr 23 2017, 5:20 PM

matej_suchanek added subscribers: adrianheine, Thryduulf, Laddo, Zppix.

daniel added a parent task: T167226: All text after a pipe character is silently removed when saving a monolingual text property.Jun 13 2017, 10:24 AM

daniel removed a project: TestMe.Jun 13 2017, 10:27 AM

daniel updated the task description. (Show Details)

daniel updated the task description. (Show Details)Jun 13 2017, 10:30 AM

daniel updated the task description. (Show Details)Jun 13 2017, 10:33 AM

daniel added a project: Wikidata-Former-Sprint-Board.

daniel updated the task description. (Show Details)

daniel added subscribers: • Jonas, thiemowmde, • Aleksey_WMDE.

daniel mentioned this in T167785: Use alternative separator character when calling wbsetaliases.Jun 13 2017, 10:35 AM

daniel updated the task description. (Show Details)

daniel added a subscriber: aude.

Izno mentioned this in T167788: [Task] Dates written as 9/7/2017 should not always be parsed as American MM/DD/YYYY.Jun 13 2017, 1:38 PM

This is indeed resolved: https://www.wikidata.org/w/api.php?action=wbparsevalue&datatype=string&values=%1Ffoo|bar%1Fbaaar|foo0

{
    "results": [
        {
            "raw": "foo|bar",
            "value": "foo|bar",
            "type": "string"
        },
        {
            "raw": "baaar|foo0",
            "value": "baaar|foo0",
            "type": "string"
        }
    ]
}

In T64925#3346908, @Ladsgroup wrote:

This is indeed resolved: https://www.wikidata.org/w/api.php?action=wbparsevalue&datatype=string&values=%1Ffoo|bar%1Fbaaar|foo0

Cool, thanks for checking!

Lydia_Pintscher moved this task from Proposed to Done on the Wikidata-Former-Sprint-Board board.Jun 20 2017, 8:11 AM

Re-opening - the issue as described was solved, but the concrete problem was not. I reworded the ticket to reflect this.

The point is: even though the API module indeed has a mechanism for using an alternative separator character, our UI code doesn't use it. We need to change that so we can process input that contains a pipe character.

daniel moved this task from Done to Backlog on the Wikidata-Former-Sprint-Board board.Jun 20 2017, 8:22 AM

daniel moved this task from Backlog to Proposed on the Wikidata-Former-Sprint-Board board.Jun 20 2017, 8:25 AM

Change 360354 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseJavaScriptApi@master] [WIP] Use alternative separator character in API requests

https://gerrit.wikimedia.org/r/360354

gerritbot added a project: Patch-For-Review.Jun 20 2017, 2:18 PM

thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.Jun 28 2017, 7:09 PM

thiemowmde mentioned this in T167226: All text after a pipe character is silently removed when saving a monolingual text property.

Change 360354 merged by jenkins-bot:
[mediawiki/extensions/WikibaseJavaScriptApi@master] Use alternative separator character in API requests

https://gerrit.wikimedia.org/r/360354

WMDE-leszek moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Jun 29 2017, 10:16 AM

Change 363786 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Update JavaScript API dependency to 2.2.1

https://gerrit.wikimedia.org/r/363786

thiemowmde claimed this task.Jul 7 2017, 8:53 AM

thiemowmde updated the task description. (Show Details)

thiemowmde moved this task from Doing to Review on the Wikidata-Former-Sprint-Board board.

thiemowmde moved this task from incoming to in progress on the Wikidata board.

thiemowmde updated the task description. (Show Details)Jul 7 2017, 11:26 AM

daniel moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Jul 10 2017, 11:36 AM

Change 363786 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Update JavaScript API dependency to 2.2.2

https://gerrit.wikimedia.org/r/363786

WMDE-leszek moved this task from Doing to Done on the Wikidata-Former-Sprint-Board board.Jul 12 2017, 11:04 AM

thiemowmde closed this task as Resolved.Jul 20 2017, 4:33 PM

thiemowmde removed a project: Patch-For-Review.