Page MenuHomePhabricator
Create Task
Maniphest T64928

X-Content-Duration header not applied to derivative transcoded .ogg and .ogv files
Closed, ResolvedPublic
Actions

Description

TimedMediaHandler's OggHandlerTMH applies an X-Content-Duration header on files, which gets returned back through our SWIFT backend etc -- this is useful for the browser or custom player widget which then doesn't have to seek in the file to find the end timestamp.

However this isn't being applied on derivative transcodes, which is a problem for my ogv.js/ogv.swf JS/Flash fallback player testing...

Source video file, includes X-Content-Duration in response:
https://upload.wikimedia.org/wikipedia/commons/f/fb/Cassini_Reveals_New_Ring_Quirks%2C_Shadows_During_Saturn_Equinox.OGG

Derivative video file, does not include X-Content-Duration in response:
https://upload.wikimedia.org/wikipedia/commons/transcoded/f/fb/Cassini_Reveals_New_Ring_Quirks%2C_Shadows_During_Saturn_Equinox.OGG/Cassini_Reveals_New_Ring_Quirks%2C_Shadows_During_Saturn_Equinox.OGG.360p.ogv

Should find a way to apply the custom header on derivatives as well, if possible...

Version: unspecified
Severity: normal

Details

Reference
bz62928

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:52 AM
• bzimport added a project: TimedMediaHandler.
• bzimport set Reference to bz62928.
• brion created this task.Mar 21 2014, 3:24 PM
gerritbot added a comment.Mar 22 2014, 2:28 AM

Change 120184 had a related patch set uploaded by Brian Wolff:
Add support for specifying headers in FileRepo::quickImport

https://gerrit.wikimedia.org/r/120184

gerritbot added a comment.Mar 22 2014, 2:33 AM

Change 120185 had a related patch set uploaded by Brian Wolff:
Set X-Content-Duration header on ogg transcodes.

https://gerrit.wikimedia.org/r/120185

gerritbot added a comment.Mar 24 2014, 6:09 AM

Change 120184 merged by jenkins-bot:
Add support for specifying headers in FileRepo::quickImport

https://gerrit.wikimedia.org/r/120184

gerritbot added a comment.Mar 26 2014, 9:04 PM

Change 120185 merged by jenkins-bot:
Set X-Content-Duration header on ogg transcodes.

https://gerrit.wikimedia.org/r/120185

Bawolff added a comment.Mar 26 2014, 9:08 PM

Should be fixed. Note this will only apply to new transcodes (once this is deployed to commons). Existing transcodes will not have the header set. Maybe should file a separate bug to do something about that (?)

• Gilles added a project: Multimedia.Dec 4 2014, 9:26 AM
• Gilles triaged this task as Unbreak Now! priority.Dec 4 2014, 10:11 AM
• Gilles moved this task from Untriaged to Done on the Multimedia board.
• Gilles lowered the priority of this task from Unbreak Now! to Needs Triage.Dec 4 2014, 11:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL