Page MenuHomePhabricator

Flow: Thanks actions on Flow pages don't show up in logging table
Closed, DeclinedPublic

Description

When you thank a user on a non-Flow enabled page, that action is registered in the logging table (log_type = "thank"). This doesn't seem to be working on Flow-enabled pages, though - which is unfortunate because that's our only method of tracking usage of the thanks feature :-/

To reproduce, in the mediawikiwiki db, Select * from logging where log_page = any Flow enabled page ID and log_action = "thank" and you won't get any results, despite the fact that we've been using the new thanks feature on those pages.


Version: master
Severity: normal

Details

Reference
bz62935

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:52 AM
bzimport added a project: Thanks.
bzimport set Reference to bz62935.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to Maryana Pinchuk from comment #0)

To reproduce, in the mediawikiwiki db, Select * from logging where log_page

any Flow enabled page ID and log_action = "thank" and you won't get any

results, despite the fact that we've been using the new thanks feature on
those pages.

log_page won't be set to the page the thank was made on, it'll be the page id of the user who was thanked.

The page which the thank was made on isn't in the logging table for any type of thanks.

AFAICT in the code, Flow-Thanks are being logged just like normal, but there is no distinction on whether they were normal thanks or Flow-Thanks.

(In reply to Kunal Mehta (Legoktm) from comment #1)

AFAICT in the code, Flow-Thanks are being logged just like normal, but there
is no distinction on whether they were normal thanks or Flow-Thanks.

You can use the EventLogging data if you want to be able to distinguish between the two.