Page MenuHomePhabricator
Create Task
Maniphest T64937

ParserTests relies on caching for non-english tests.
Closed, ResolvedPublic
Actions

Description

I'm looking at a weird parsertests issue where tests for Archivo:Foobar.jpg only succeed iff a test with File:Foobar.jpg was run previously, which causes "Foobar.jpg" to be added to env.pageCache
Maybe we should empty out pageCache for each test? or when the test has a non-default language? not sure how this should be fixed.
mockAPI doesn't recognize Archivo:Foobar.jpg as a valid file, which is part of the issue.

to reproduce easily, change 'if (queueKey in env.pageCache)' to 'if (false)' in ext.core.LinkHandler and re-run parsertests.

Version: unspecified
Severity: normal

Details

Reference
bz62937

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:52 AM
• bzimport added projects: Parsoid-Tests, good first task.
• bzimport set Reference to bz62937.
cscott created this task.Mar 21 2014, 9:08 PM
Arlolra added a project: Parsoid.Nov 25 2014, 6:56 PM
Arlolra set Security to None.
ssastry moved this task from Needs Triage to Testing on the Parsoid board.Dec 20 2014, 1:10 AM
• marcoil moved this task from Testing to Needs Triage on the Parsoid board.Feb 13 2015, 12:50 PM
Aklapper subscribed.Dec 15 2016, 2:38 PM

@cscott: This issue has been assigned to you two years ago. Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anything that others could help with? In case you do not plan to work on this issue anymore, should you be removed as assignee (via 'Assign / Claim' in the 'Actions' dropdown menu) to avoid cookie-licking?

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptDec 15 2016, 2:38 PM
Aklapper added a comment.Dec 15 2016, 2:38 PM

@cscott: This issue has been assigned to you two years ago. Could you please share a status update? Are you still working (or still plan to work) on this issue? Is there anything that others could help with? In case you do not plan to work on this issue anymore, should you be removed as assignee (via 'Assign / Claim' in the 'Actions' dropdown menu) to avoid cookie-licking?

cscott closed this task as Resolved.Dec 1 2017, 9:05 PM

Seems to have been fixed sometime since March 2014:

bin/parserTests.js --filter "Localized image handling" --wt2html

has no problems now, and indeed the problematic if (queueKey in env.pageCache) doesn't exist in LinkHandler any more.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL