Page MenuHomePhabricator

Install puppet-lint and create a puppet-lint job
Closed, ResolvedPublic

Description

We should get puppet-lint installed from rubygems on the Jenkins labs slave then get a job to run it on all puppet repositories. http://puppet-lint.com/ .

Luckily puppet supports the gem provider :-}


Version: wmf-deployment
Severity: normal

Details

Reference
bz62955

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:53 AM
bzimport set Reference to bz62955.
bzimport added a subscriber: Unknown Object (MLST).

puppet-lint is available as an Ubuntu package:

Package: puppet-lint
State: not installed
Version: 0.1.7-1
Priority: optional
Section: universe/ruby
Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
Architecture: all
Uncompressed Size: 85.0 k
Depends: rubyruby-interpreter, puppet-common
Suggests: rake
Description: check puppet manifests for style guide conformity
Checks your Puppet manifests against the Puppet Labs style guide and alerts you
to any discrepancies.
This program checks spacing, indentation, whitespace, quoting, conditionals and
classes.
Homepage: https://github.com/rodjek/puppet-lint/

0.1.7 is from two years ago, we can use gem in labs :-]

Change 120498 had a related patch set uploaded by Hashar:
contint: install puppet-lint from rubygems on labs

https://gerrit.wikimedia.org/r/120498

Change 120498 abandoned by Hashar:
contint: install puppet-lint from rubygems on labs

Reason:
puppet-lint debian package got back ported. See RT #7154

https://gerrit.wikimedia.org/r/120498

We have puppet-lint using the backported Debian package. I have added template in Jenkins Job Builder and added puppet lint to operations/puppet and translatewiki git repositories.