ParserOutputJsConfigBuilder.php: $entity has no entity id
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Addshore
	Mar 22 2014, 10:10 PM

Description

Exception thrown on both beta and test wikidata when creating a new item using Special:NewItem

Unexpected non-MediaWiki exception encountered, of type "RuntimeException"
[71a0c0dc] /wiki/Special:NewItem Exception from line 103 of /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/ParserOutputJsConfigBuilder.php: $entity has no entity id
Backtrace:
#0 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/ParserOutputJsConfigBuilder.php(86): Wikibase\ParserOutputJsConfigBuilder->getEntityVars(Wikibase\DataModel\Entity\Item, Wikibase\Lib\Serializers\SerializationOptions)
#1 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/EntityView.php(323): Wikibase\ParserOutputJsConfigBuilder->build(Wikibase\DataModel\Entity\Item, Wikibase\Lib\Serializers\SerializationOptions, boolean)
#2 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/content/EntityContent.php(149): Wikibase\EntityView->getParserOutput(Wikibase\EntityRevision, boolean, boolean)
#3 /data/project/apache/common-local/php-master/extensions/SpamBlacklist/SpamBlacklistHooks.php(28): Wikibase\EntityContent->getParserOutput(Title)
#4 [internal function]: SpamBlacklistHooks::filterMergedContent(RequestContext, Wikibase\ItemContent, Status, string, User, boolean)
#5 /data/project/apache/common-local/php-master/includes/Hooks.php(206): call_user_func_array(string, array)
#6 /data/project/apache/common-local/php-master/includes/GlobalFunctions.php(4011): Hooks::run(string, array, NULL)
#7 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(767): wfRunHooks(string, array)
#8 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/EditEntity.php(698): Wikibase\EditEntity->runEditFilterHooks(string)
#9 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/specials/SpecialWikibaseRepoPage.php(180): Wikibase\EditEntity->attemptSave(string, integer, string)
#10 /data/project/apache/common-local/php-master/extensions/Wikidata/extensions/Wikibase/repo/includes/specials/SpecialNewEntity.php(116): Wikibase\Repo\Specials\SpecialWikibaseRepoPage->saveEntity(Wikibase\DataModel\Entity\Item, Wikibase\Summary, string, integer)
#11 /data/project/apache/common-local/php-master/includes/specialpage/SpecialPage.php(376): Wikibase\Repo\Specials\SpecialNewEntity->execute(NULL)
#12 /data/project/apache/common-local/php-master/includes/specialpage/SpecialPageFactory.php(490): SpecialPage->run(NULL)
#13 /data/project/apache/common-local/php-master/includes/Wiki.php(285): SpecialPageFactory::executePath(Title, RequestContext)
#14 /data/project/apache/common-local/php-master/includes/Wiki.php(588): MediaWiki->performRequest()
#15 /data/project/apache/common-local/php-master/includes/Wiki.php(447): MediaWiki->main()
#16 /data/project/apache/common-local/php-master/index.php(49): MediaWiki->run()
#17 /data/project/apache/common-local/w/index.php(3): require(string)
#18 {main}

Version: unspecified
Severity: blocker
Whiteboard: u=dev c=backend p=1 s=2014-03-18

Details

Reference: bz62965

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 2:54 AM

• bzimport added a project: MediaWiki-extensions-WikibaseRepository.

• bzimport set Reference to bz62965.

• bzimport added a subscriber: Unknown Object (MLST).

Addshore created this task.Mar 22 2014, 10:10 PM

This is the second recent bug that has slipped through everything as it comes from the SpamBlacklistHooks call.

Maybe we should test with spamblacklist?
Or at least run selenium tests against the special pages with spamblacklist!

Change 120322 had a related patch set uploaded by Addshore:
Fix RuntimeException in Special:Newitem with SpamBlacklist

https://gerrit.wikimedia.org/r/120322

Yes we should!

Change 120323 had a related patch set uploaded by Addshore:
Fix RuntimeException in Special:Newitem with SpamBlacklist

https://gerrit.wikimedia.org/r/120323

Change 120324 had a related patch set uploaded by Addshore:
Fix RuntimeException in Special:Newitem with SpamBlacklist

https://gerrit.wikimedia.org/r/120324

Change 120322 merged by Jeroen De Dauw:
Fix RuntimeException in Special:Newitem with SpamBlacklist

https://gerrit.wikimedia.org/r/120322

Change 120324 abandoned by Addshore:
Fix RuntimeException in Special:Newitem with SpamBlacklist

Reason:
We have so much going into the build branch now we might as well make composer do all this at once!