librsvg misinterpret quoted font family names that contain whitespaces
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Perhelion
	Mar 23 2014, 7:40 PM

Description

File:Meta SVG fonts.svg

When specifying a font family with whitespaces it is recommended to escaping this in quotes, but the SVG rendering engine couldn't interpret this.

https://www.w3.org/TR/SVG/text.html#FontFamilyProperty
http://www.w3.org/TR/CSS2/fonts.html#font-family-prop

(Here the attached file source without quotes [[:file:Meta_SVG_fonts.svg]], one with CSS and one with SVG own property)

Update
Reopened (2017-05-20) as the upstream fix included in librsvg 2.40.10. was only for the CSS property.

Version: unspecified
Severity: normal
See Also:
https://gitlab.gnome.org/GNOME/librsvg/issues/319
T25643: Allow alternative declaration of SVG fonts (font-family="'FontName-Bold'" in addition to: font-family="Font name" font-weight="bold")

Attached:

20140308165757_Test.svg4 KBDownload

CSS property fixed

20140308165757_Test1c.svg4 KBDownload

SVG attribute not fixed

Details

Reference: bz62987

Related Objects
Search...

Status	Assigned	Task
Resolved	JoKalliauer	T64987 librsvg misinterpret quoted font family names that contain whitespaces
Resolved	hnowlan	T193352 Update librsvg to ≥2.42.3 (2.44.10)
Resolved	hnowlan	T216815 Upgrade Thumbor to Buster
Invalid	None	T212941 Investigate systemd hardening to replace Firejail for Thumbor
Resolved	fgiunchedi	T212946 Stream Thumbor logs to logstash
Resolved	• Gilles	T187765 Replace the Nginx fronting Thumbor with Haproxy
Resolved	fgiunchedi	T204266 Backport prometheus haproxy exporter for Jessie
Resolved	jijiki	T220499 Export useful metrics from haproxy logs for Thumbor
Resolved	jijiki	T221562 Build Thumbor packages for buster

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:56 AM

• bzimport added a project: Wikimedia-SVG-rendering.

• bzimport set Reference to bz62987.

• bzimport added a subscriber: Unknown Object (MLST).

Perhelion created this task.Mar 23 2014, 7:40 PM

Menner updated the task description. (Show Details)May 15 2015, 9:07 AM

Menner set Security to None.

Menner added a project: Upstream.May 29 2015, 6:28 PM

Fixed in upstream librsvg; patch will be included in librsvg 2.40.10.

Fix included in version 2.40.10 which got released now. Now need to backport or need to wait for the distribution used on Wikimedia servers to provide that version....

Menner added a subtask: T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).Sep 14 2015, 6:37 AM

Ricordisamoa subscribed.Sep 14 2015, 8:44 AM

Tgr mentioned this in T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).Sep 14 2015, 11:45 PM

MoritzMuehlenhoff added a project: SRE.Jun 23 2016, 9:50 AM

That bug is fixed on the new jessie image scaler using 2.4.16 (tested locally, it's not yet pooled into the set of active scalers in production).
I have scaled 20140308165757_Test.svg on the new and the present image scalers and put the results at https://people.wikimedia.org/~jmm/svg/ :

whitespace-new.png : Result with new librsvg
whitespace-old.png : Result with old librsvg

MoritzMuehlenhoff claimed this task.Jun 23 2016, 10:08 AM

MoritzMuehlenhoff closed subtask T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues) as Resolved.Jul 4 2016, 2:46 PM

The image scalers are now using 2.40.16 containing th upstream fix.

Anyway the disfunction is still present if not CSS but on SVG attribute font-family.

20140308165757_Test1c.svg4 KBDownload

Perhelion reopened this task as Open.May 20 2017, 11:28 AM

@Perhelion: Does that mean https://bugzilla.gnome.org/show_bug.cgi?id=739329 should be reopened? If not, would you please file a separate task?

In T64987#3279102, @Aklapper wrote:

@Perhelion: Does that mean https://bugzilla.gnome.org/show_bug.cgi?id=739329 should be reopened? If not, would you please file a separate task?

@Aklapper: Yes the bug upstream should be reopened, I commented there.

Perhelion updated the task description. (Show Details)May 21 2017, 6:55 AM

Perhelion updated the task description. (Show Details)May 21 2017, 6:58 AM

MoritzMuehlenhoff removed MoritzMuehlenhoff as the assignee of this task.Jul 17 2017, 8:56 AM

Aklapper moved this task from Patch merged upstream to Reported Upstream on the Upstream board.Oct 25 2017, 12:04 PM

JoKalliauer mentioned this in T184369: font-family="'font name'" and style="font-family:'font name'" does not work in SVG rendering.Jul 18 2018, 9:40 PM

Glrx mentioned this in T190947: Liberation Sans font-family don't work in SVG rendering for SVG files created with Adobe Illustrator.Jul 18 2018, 9:50 PM

Glrx subscribed.

JoKalliauer merged a task: T184369: font-family="'font name'" and style="font-family:'font name'" does not work in SVG rendering.Jul 18 2018, 10:00 PM

JoKalliauer added subscribers: JoKalliauer, MaxSem, Incnis_Mrsi, zhuyifei1999.

Merged from T184369

If you use (quote and double-quote)

font-family="'font name'"

instead of

font-family="font name"

font-family='font name'

Wiki-Parser don't notice the correct font.
By default Inkscape adds ' ' if the font name has a space like in "Liberation Serif" or "DejaVu Sans" like style="font-family:'Bitstream Charter'"
Scour changes it to: font-family="'Bitstream Charter'" which doesn't help.

BugReport-Example:
T184369.svg (filelink)
Rendered by Wiki-Parser:

Converted by Inkscape:

MediaWiki_SVG_font_list_serif.png (210×1 px, 109 KB)

Examples:

@Aklapper : I merged it here, because this was the first time reported, but I think T184369 pointed it out more clearly, was easier to understand, faster to see, included a rendered example,... Should descriptions be updated, if they can be improved? (I think in bugreports it is unimportant who repots it, it is important that you can see the problem in few seconds and the description should be understandable by laypersons on Commons. Since I did here too many mistakes the last days, would you do that for me or/and explain?

Aklapper updated the task description. (Show Details)Jul 18 2018, 10:19 PM

Aklapper removed a subscriber: • wikibugs-l-list.

Niridya subscribed.Jul 18 2018, 11:04 PM

Niridya merged a task: T190947: Liberation Sans font-family don't work in SVG rendering for SVG files created with Adobe Illustrator.Jul 19 2018, 12:03 PM

Niridya updated the task description. (Show Details)Jul 19 2018, 12:06 PM

Aklapper mentioned this in T25643: Allow alternative declaration of SVG fonts (font-family="'FontName-Bold'" in addition to: font-family="Font name" font-weight="bold").Jul 21 2018, 12:24 PM

Aklapper updated the task description. (Show Details)Aug 4 2018, 8:22 AM

Glrx updated the task description. (Show Details)Aug 4 2018, 2:02 PM

Liuxinyu970226 updated the task description. (Show Details)Oct 30 2018, 4:21 AM

Liuxinyu970226 subscribed.

Gnome closed issue 319 on 23 August 2018 with commit https://gitlab.gnome.org/GNOME/librsvg/commit/3d84acca9c11482cb0d2f75d379086be21bd4c91

So bug is presumably fixed in Rust-version of librsvg but MW blocked on installing Rust version.

It's included in 2.44.0 according to https://gitlab.gnome.org/GNOME/librsvg/commit/18a4f166c4faf590988823c472bd0333fcf7d1e7

Liuxinyu970226 awarded a token.Nov 11 2018, 12:26 PM

• Phabricator_maintenance moved this task from Backlog to Acknowledged on the SRE board.Jan 26 2019, 7:50 PM

jijiki added a parent task: T193352: Update librsvg to ≥2.42.3 (2.44.10).Mar 11 2019, 6:36 AM

jijiki added a project: Thumbor.

AntiCompositeNumber removed a parent task: T193352: Update librsvg to ≥2.42.3 (2.44.10).May 14 2020, 4:04 AM

AntiCompositeNumber added a subtask: T193352: Update librsvg to ≥2.42.3 (2.44.10).

AntiCompositeNumber moved this task from Backlog to Upstream on the Thumbor board.

AntiCompositeNumber removed a subtask: T112421: Update rsvg on the image scalers to 2.40.16 (to solve several SVG rendering issues).

AntiCompositeNumber moved this task from Upstream to Upstream (librsvg) on the Thumbor board.May 22 2020, 4:03 AM

toorich changed the status of subtask T193352: Update librsvg to ≥2.42.3 (2.44.10) from Stalled to Open.Jun 24 2020, 9:59 AM

Aklapper changed the status of subtask T193352: Update librsvg to ≥2.42.3 (2.44.10) from Open to Stalled.Jun 24 2020, 10:34 AM

JoKalliauer changed the task status from Open to Stalled.Jun 30 2021, 3:04 PM

JoKalliauer moved this task from Backlog to update librsvg on the Wikimedia-SVG-rendering board.

hnowlan closed subtask T193352: Update librsvg to ≥2.42.3 (2.44.10) as Resolved.May 17 2023, 11:36 AM

file	https://commons.wikimedia.org/wiki/File:T184369.svg
librsvg2.40
librsvg2.44

it seems to be fixed

Glrx mentioned this in T344564: Font substitution for SVG file to PNG thumbnail replaces serif with sans-serif font.Sep 5 2023, 1:32 AM

	F12299880: MediaWiki_SVG_font_list_serif.png
	Jul 18 2018, 10:12 PM

	F37007077: T184369.svg.png
	May 18 2023, 1:23 AM

librsvg misinterpret quoted font family names that contain whitespacesClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

librsvg misinterpret quoted font family names that contain whitespaces
Closed, ResolvedPublic
Actions

Related Objects
Search...