Page MenuHomePhabricator

coordinate_import.py: allow non-wikipedia sources
Closed, ResolvedPublic

Description

  1. getSource / cacheSources should be moved to a more general class, so all WD bots can use it, and
  2. getSource / cacheSources is now wikipedia-specific, and I think there is already a non-WP-specific version around in one of the other WD bots.

Version: core-(2.0)
Severity: normal

Details

Reference
bz62991

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:56 AM
bzimport set Reference to bz62991.

Change 126213 had a related patch set uploaded by Ricordisamoa:
create a new WikidataBot class for cacheSources() and getSource() for claimit.py, coordinate_import.py and harvest_template.py

https://gerrit.wikimedia.org/r/126213

Change 126213 merged by jenkins-bot:
create a new WikidataBot class for cacheSources() and getSource() for claimit.py, coordinate_import.py and harvest_template.py

https://gerrit.wikimedia.org/r/126213

  • This bug has been marked as a duplicate of bug 62438 ***

(In reply to Merlijn van Deen from comment #3)

  • This bug has been marked as a duplicate of bug 62438 ***

Even if a single patch resolved both, I am not sure they are exactly the same.

I considered them 'the same' as they were both bugs about refactoring getSource/cacheSource into a common library -- but you could consider the non-WP-source as a 'feature request' for coordinate_import.py. Considering it 'res/fixed' is also fine with me :-)

Actually, I don't care much of this. Just leave it as it is :-)