Page MenuHomePhabricator

PHP Fatal error: Call to a member function getEntity() on a non-object in repo/includes/EditEntity.php on line 488
Closed, ResolvedPublic

Description

also an issue on line 492.

@note - this is spotted in the mw1.23-wmf19 branch. line numbers might be different in master

PHP Fatal error: Call to a member function getEntity() on a non-object in /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/in cludes/EditEntity.php on line 488

PHP Stack trace:

  1. {main}() /Library/WebServer/Documents/php-master/api.php:0
  2. ApiMain->execute() /Library/WebServer/Documents/php-master/api.php:86
  3. ApiMain->executeActionWithErrorHandling() /Library/WebServer/Documents/php-4. ApiMain->executeAction() /Library/WebServer/Documents/php-master/includes/api/ApiMain.php:363
  4. Wikibase\Api\SetClaim->execute() /Library/WebServer/Documents/php-master/includes/api/ApiMain.php:899
  5. Wikibase\Api\ModifyClaim->saveChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/api/SetClaim.php:69
  6. Wikibase\Api\ApiWikibase->attemptSaveEntity() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/api/ModifyClaim.php:79
  7. Wikibase\EditEntity->attemptSave() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/api/ApiWikibase.php:513
  8. Wikibase\EditEntity->applyPreSaveChecks() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/EditEntity.php:726
  9. Wikibase\EditEntity->fixEditConflict() /Library/WebServer/Documents/php-master/extensions/Wikibase/repo/includes/EditEntity.php:823

Version: master
Severity: normal
Whiteboard: u=dev c=backend p=3 s=2014-03-18

Details

Reference
bz63009

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:57 AM
bzimport set Reference to bz63009.
bzimport added a subscriber: Unknown Object (MLST).

Change 120529 had a related patch set uploaded by Hoo man:
Don't assume we have a conflict if no base rev is known in EditEntity

https://gerrit.wikimedia.org/r/120529

the issue I had was an edge case, I think with my item missing in the wb_entity_per_page table.

the problem shouldn't happen on wikidata, but never know.

I think there are places in EditEntity where it can be made more robust for this and who knows what other edge cases.

Change 120529 merged by jenkins-bot:
Don't assume we have a conflict if no base rev is known in EditEntity

https://gerrit.wikimedia.org/r/120529

Aude: I guess we can consider this fixed?!

Marking as resolved per Aude