Page MenuHomePhabricator
Create Task
Maniphest T65053

UploadWizard CSS is loaded twice
Closed, ResolvedPublic
Actions

Description

Due to 0a1a638553579d4effda75dc3c8f6e75aed97e15 (which was apparently intended to fix a FUOC), the styles are now loaded twice (once via the JavaScript ResourceLoader loader, and another time via addModuleStyles).

I think the correct solution is to make a separate module for styles that apply to HTML delivered from the server, and load that in the top queue. These styles should then be removed from the main module.

This top queue module could use addModuleStyles so at least the error text renders right if the browser doesn't have JavaScript.

Version: master
Severity: normal
See Also: T36601

Details

Reference
bz63053

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:00 AM
• bzimport added a project: UploadWizard.
• bzimport set Reference to bz63053.
• bzimport added a subscriber: Unknown Object (MLST).
• Mattflaschen-WMF created this task.Mar 25 2014, 2:00 AM
• Mattflaschen-WMF added a comment.Mar 25 2014, 2:05 AM

(In reply to Matthew Flaschen from comment #0)

This top queue module could use addModuleStyles so at least the error text
renders right if the browser doesn't have JavaScript.

It doesn't look like UploadWizard has any custom error styles. This might not be an issue, in which case they could both use addModules, with one just having 'position' => 'top'.

• Gilles triaged this task as Low priority.Nov 24 2014, 2:48 PM
• Gilles subscribed.
• Gilles added a project: Multimedia.Nov 24 2014, 3:14 PM
matmarex closed this task as Resolved.May 16 2015, 2:51 PM
matmarex assigned this task to • Gilles.
matmarex updated the task description. (Show Details)
matmarex set Security to None.
matmarex subscribed.

Fixed by https://gerrit.wikimedia.org/r/#/c/209688/ / 0cca78c4f7858633af1d22fb78736f5114b61cca.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL