Page MenuHomePhabricator

VisualEditor: Link can be applied on Cite Web/Book/Newspaper/Journal templates (but not reference nodes), which is confusing
Open, LowPublic

Description

Screenshot

Steps to reproduce:

1.Open a page with VE
2.Add a text then a Cite>Website/Book/Newspaper/Journal just after that
3.Now select both the text and the cite
4.Apply link on it

Observed Result:
The link also gets applied on the Cite

See the screenshot attached

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/wiki/Reference_numbering?veaction=edit


Version: unspecified
Severity: minor

Attached:

Screen_Shot_2014-03-25_at_3.27.05_PM.png (467×613 px, 39 KB)

Details

Reference
bz63091

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:02 AM
bzimport set Reference to bz63091.

This is hard to fix. Blacklisted annotation types are done on a per-node-type basis. Normal references are of type 'mwReference', but citations are of type 'mwTransclusionInline', and I don't think it's a good idea to make all templates unlinkable.

For templates we may need to have some kind of function that dynamically determines whether the template is linkable :(