Page MenuHomePhabricator
Create Task
Maniphest T65132

VisualEditor: Cannot close the Media Settings dialog as the error Uncaught TypeError: Object #<VeDmMWMathNode> has no method 'getCaptionNode' appears in the console
Closed, ResolvedPublic
Actions

Description

screenshot

Steps to reproduce:

1.Open a page with VE
2.Open the math inspector
3.Keep it open
4.Insert an image
5.Select the image
6.Click on undo
7.Click on the media settings icon that is still appearing at the right corner of the page

Observed Result:

The Media Settings dialog box appears with empty caption field .An error appears in the console:
Uncaught TypeError: Object #<VeDmMWMathNode> has no method 'getCaptionNode'

Also, you will not be able to close the Media Settings dialog box and will get stuck at this step.

See the screenshot attached.

Test Environment: http://en.wikipedia.beta.wmflabs.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Page:http://en.wikipedia.beta.wmflabs.org/wiki/User:RYasmeen_%28WMF%29?veaction=edit

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-03-26_at_11.11.26_AM.png (749×1 px, 181 KB)

Details

Reference
bz63132

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:05 AM
• bzimport added projects: VE-deploy-2014-05-08, VisualEditor-EditingTools.
• bzimport set Reference to bz63132.
Ryasmeen created this task.Mar 26 2014, 7:01 PM
Catrope added a comment.Mar 26 2014, 10:18 PM

This seems to be because MediaEditDialog is launched for an MWMathNode, which shouldn't be possible. Assigned to Trevor as the fact that we even got here is a bug in the tools system.

MediaEditDialog also shouldn't crash in this case, but Moriel is already going to merge the insertion and edit dialogs, so that should take care of that issue.

Jdforrester-WMF added a comment.May 30 2014, 5:49 PM

I believe that this is now fixed – please confirm.

Ryasmeen added a comment.May 30 2014, 6:33 PM

Yes, Checked in production,appears to be fixed.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:04 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:36 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL