Page MenuHomePhabricator

Hovercards: When image is not masked by pin should use main popup height
Closed, DeclinedPublic

Description

top of image clipped unnecessarily

Only when the image is masked by the pin should its height be stretched taller than the popup.


Version: unspecified
Severity: normal
OS: Mac OS X 10.9
Platform: Macintosh

Attached:

Screenshot_2014-03-26_18.47.39.png (331×549 px, 160 KB)

Details

Reference
bz63162

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:07 AM
bzimport added a project: Page-Previews.
bzimport set Reference to bz63162.

This is a decision that Vibha and I consciously took. As the proportions of these images can vary we have a fixed size box and the image stretches/clips to fit that area. Keeps the Hovercard clean.

Any suggestions are welcome!

We might want to revisit this, but we can talk more

Created attachment 14950
cropping issue

Attached:

Screenshot_2014-03-27_16.20.36.png (1×1 px, 1 MB)

I attached another issue about cropping, masking, and enlarging, unsure if its the same issue.

Yes it is the same issue, enlarging an image to fit a a specific size and ratio.

Jared's point is about photo composition, duly noted. Lets revisit this once the the major usability and visual bugs have been fixed. Assigning it to myself so I can manage bugs that have visual impact for the user.

  • Bug 65242 has been marked as a duplicate of this bug. ***

Merging comments from bug 65242:

Attachment 15363 (logo crop)
Attachment 15364 (album crop)
Attachment 15365 (portrait crop)

(Quiddity wrote)

Images are cropped in Hovercards, which sometimes looks quite bad.
Particularly logos (screenshot 1) and album covers (screenshot 2).
Occasionally portraits of people will be cut off right in their hairline
(screenshot 3).

The best of our images, are already scrupulously cropped/framed, so it would
be ideal to present to readers, exactly the images that our editors intended.

(Eduard Braun wrote)

This is also an issue for all graphical illustrations like diagrams,
chemical structure formulae, geometric sketches, etc.

dr0ptp4kt subscribed.

Closing for the time being.