Page MenuHomePhabricator

OAuth should pass jslint
Closed, DeclinedPublic

Description

jshint reports failure on javascript files and should be fixed. Whenever this is done, one can make the jslint job to be voting by editing integration/zuul-config.git layout.yaml file and remove the line that make the jslint job to be non voting.


Version: master
Severity: normal

Details

Reference
bz63221

Related Objects

StatusSubtypeAssignedTask
ResolvedPaladox
DeclinedNone

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:54 AM
bzimport set Reference to bz63221.
bzimport added a subscriber: Unknown Object (MLST).

Change 121636 had a related patch set uploaded by Siebrand:
Make jslint non-voting for OAuth

https://gerrit.wikimedia.org/r/121636

Change 121636 abandoned by Hashar:
Make jslint non-voting for OAuth

Reason:
OAuth is passing as shown on the last change merged in: https://gerrit.wikimedia.org/r/#/c/93918/

You probably got hit by https://bugzilla.wikimedia.org/show_bug.cgi?id=52456 which can be solved by added a dummy .jshintrc in the repository that would contain:
{}

https://gerrit.wikimedia.org/r/121636

Closing bug per my comment above.