Page MenuHomePhabricator
Create Task
Maniphest T65240

ResourceLoader: Remove support for 'startupScripts' and 'loaderScripts' feature
Closed, ResolvedPublic
Actions

Description

They're evil, and only TimedMediaHandler uses them. Get rid of this misfeature.

Details

Reference
bz63240
SubjectRepoBranchLines +/-
resourceloader: Remove unused makeCustomLoaderScript() methodmediawiki/coremaster+0 -25
resourceloader: Remove 'loaderScripts' option from FileModulemediawiki/coremaster+3 -60
Customize query in gerrit

Revisions and Commits

rMW MediaWiki
rMW7fb6675a8f8f Remove ResourceLoaderGetStartupModules hook

Related Objects
Search...

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:55 AM
• bzimport added a project: MediaWiki-ResourceLoader.
• bzimport set Reference to bz63240.
• bzimport added a subscriber: Unknown Object (MLST).
Catrope created this task.Mar 28 2014, 9:30 PM
gerritbot added a comment.Apr 20 2014, 9:03 PM

Change 127581 had a related patch set uploaded by Ori.livneh:
Deprecate ResourceLoaderGetStartupModules

https://gerrit.wikimedia.org/r/127581

gerritbot added a comment.Apr 20 2014, 9:23 PM

Change 127581 merged by jenkins-bot:
Deprecate ResourceLoaderGetStartupModules

https://gerrit.wikimedia.org/r/127581

gerritbot added a comment.Apr 20 2014, 9:25 PM

Change 127582 had a related patch set uploaded by Ori.livneh:
Deprecate ResourceLoaderGetStartupModules

https://gerrit.wikimedia.org/r/127582

gerritbot added a comment.Apr 20 2014, 9:29 PM

Change 127582 merged by jenkins-bot:
Deprecate ResourceLoaderGetStartupModules

https://gerrit.wikimedia.org/r/127582

matmarex added a comment.Apr 20 2014, 10:09 PM

Deprecated, not yet removed.

Krinkle lowered the priority of this task from Medium to Low.Dec 10 2014, 1:51 PM
Krinkle added a project: Technical-Debt.
Krinkle updated the task description. (Show Details)
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
Nemo_bis awarded a token.Dec 12 2014, 8:01 AM
Tgr mentioned this in T85262: Add startup script to automatically wrap asynchronous functions in try..catch.Dec 24 2014, 8:33 PM
Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Apr 28 2015, 5:38 PM
TheDJ added a subtask: T74675: Dynamically loading TimedMediaHandler for new content (preview).Apr 29 2015, 12:58 PM
TheDJ closed subtask T74675: Dynamically loading TimedMediaHandler for new content (preview) as Resolved.Aug 7 2015, 7:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2015, 7:00 PM
TheDJ closed subtask T74675: Dynamically loading TimedMediaHandler for new content (preview) as Resolved.Aug 7 2015, 7:00 PM
TheDJ reopened subtask T74675: Dynamically loading TimedMediaHandler for new content (preview) as Open.Aug 7 2015, 7:03 PM
TheDJ added a comment.Oct 19 2015, 7:14 PM

TMH is switched around now, so this is GONE !!!

TheDJ closed this task as Resolved.Oct 19 2015, 7:15 PM
TheDJ claimed this task.
TheDJ closed subtask T74675: Dynamically loading TimedMediaHandler for new content (preview) as Resolved.Oct 19 2015, 7:21 PM
Krinkle added a commit: rMW7fb6675a8f8f: Remove ResourceLoaderGetStartupModules hook.Oct 19 2015, 7:33 PM
matmarex added a comment.Oct 19 2015, 7:44 PM

Did we kill the feature, or just the usage?

Krinkle renamed this task from ResourceLoader: Get rid of startupScripts to ResourceLoader: Remove support for 'startupScripts' and 'loaderScripts' feature.Oct 19 2015, 11:03 PM
gerritbot subscribed.Oct 19 2015, 11:04 PM

Change 247475 had a related patch set uploaded (by Krinkle):
resourceloader: Remove 'loaderScripts' option from FileModule

https://gerrit.wikimedia.org/r/247475

gerritbot added a project: Patch-For-Review.Oct 19 2015, 11:04 PM
matmarex added a comment.Oct 20 2015, 11:39 AM
In T65240#656500, @matmarex wrote:

Deprecated, not yet removed.

ResourceLoaderGetStartupModules was removed in 7fb6675a8f8f98f836cd44f827b7c94393e16afc.

TheDJ reopened this task as Open.Oct 20 2015, 11:48 AM
TheDJ reassigned this task from TheDJ to Krinkle.
TheDJ edited subtasks, added: T60085: TimedMediaHandler should not add start-up scripts; removed: T74675: Dynamically loading TimedMediaHandler for new content (preview).

Let's keep this open a little bit longer... until we merge 247475

TheDJ closed subtask T60085: TimedMediaHandler should not add start-up scripts as Resolved.Oct 20 2015, 11:50 AM
gerritbot added a comment.Oct 28 2015, 2:53 PM

Change 247475 merged by jenkins-bot:
resourceloader: Remove 'loaderScripts' option from FileModule

https://gerrit.wikimedia.org/r/247475

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)).Oct 28 2015, 4:00 PM
TheDJ closed this task as Resolved.Oct 28 2015, 4:24 PM
Krinkle moved this task from Accepted Enhancement to Assigned on the MediaWiki-ResourceLoader board.Aug 19 2016, 6:35 AM
Krinkle edited projects, added Performance-Team; removed MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)), Patch-For-Review.May 11 2017, 6:06 PM
gerritbot added a comment.Sep 15 2018, 9:15 PM

Change 460713 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] resourceloader: Remove unused makeCustomLoaderScript() method

https://gerrit.wikimedia.org/r/460713

gerritbot added a project: Patch-For-Review.Sep 15 2018, 9:15 PM
gerritbot added a comment.Sep 17 2018, 6:44 PM

Change 460713 merged by jenkins-bot:
[mediawiki/core@master] resourceloader: Remove unused makeCustomLoaderScript() method

https://gerrit.wikimedia.org/r/460713

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 17 2018, 7:00 PM
DannyS712 mentioned this in T289108: Remove ResourceLoader loaderScripts feature from extension.json schema.Aug 18 2021, 5:50 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL