Page MenuHomePhabricator

Styling issues in search overlay
Closed, ResolvedPublic

Description

Exhibit 1

There are a few styling issues with the search overlay in stable.


Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-03-28_at_4.51.58_PM.png (388×878 px, 48 KB)

Details

Reference
bz63246

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:55 AM
bzimport set Reference to bz63246.
bzimport added a subscriber: Unknown Object (MLST).

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1818

Created attachment 14968
Exhibit 2

Attached:

Screen_Shot_2014-03-28_at_4.52.05_PM.png (311×875 px, 30 KB)

Did some investigation and this is due to one of the deprecated hacks in stable:

// Deprecated rules
.stable {

// this makes sure mobile browsers don't zoom on inputs (minimum resulting
// font size has to be 16px)
// header font size is kept the same to make it consistent with the search input
input,
textarea,
.header,
.overlay-header {
  font-size: round( 1em / @fontScalingFactor, 2 );
}

}

Working around it would require adding a bunch of similar hacks elsewhere. My suggestion would be to promote TypographyNew.less to stable instead and get rid of the rule above.

Change 124034 had a related patch set uploaded by JGonera:
Fix styling of "No page with this title" in search

https://gerrit.wikimedia.org/r/124034

Change 124034 merged by jenkins-bot:
Fix styling of "No page with this title" in search

https://gerrit.wikimedia.org/r/124034