Page MenuHomePhabricator

searchGetNearMatchBeforeHook - incorrect parameter specification
Closed, ResolvedPublic

Description

Author: bobdye

Description:
The MediaWiki 'SearchGetNearMatchBefore' hook passes the second parameter ($titleResult) by reference.

Because it is not defined as being by reference in the searchGetNearMatchBeforeHook function definition, the result is never returned to MediaWiki.


Version: master
Severity: normal

Details

Reference
bz63268

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:57 AM
bzimport added a project: CirrusSearch.
bzimport set Reference to bz63268.
bzimport added a subscriber: Unknown Object (MLST).

Change 122551 had a related patch set uploaded by Chad:
Fix incorrect hook usage, second parameter is a reference

https://gerrit.wikimedia.org/r/122551

Change 122551 merged by jenkins-bot:
Fix incorrect hook usage, second parameter is a reference

https://gerrit.wikimedia.org/r/122551

Thanks for the report! This is now fixed in master.