The styleguide:
https://github.com/styleguide/ruby
Repositories with Ruby code:
https://github.com/wikimedia/mediawiki-selenium#links
Version: wmf-deployment
Severity: normal
Whiteboard: zfilipin
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=69245
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Ignoring RuboCop rule Style/Alias | mediawiki/ruby/api | master | +3 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Declined | None | T62335 Implement Ruby/Selenium/Cucumber/page-object coding conventions | |||
| Resolved | zeljkofilipin | T65307 Review if existing Ruby code follows Ruby Styleguide |
This will be easy to do when bug 69245 is resolved.
New Ruby coding conventions:
https://www.mediawiki.org/wiki/Manual:Coding_conventions/Ruby
Selenium coding conventions:
https://www.mediawiki.org/wiki/Manual:Coding_conventions/Selenium
Change 168277 had a related patch set uploaded by Zfilipin:
Fixed Style/BracesAroundHashParameters RuboCop offense
Change 168279 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/Alias
Change 168281 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/DotPosition
Change 168283 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/LeadingCommentSpace
Change 168284 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/PercentLiteralDelimiters
Change 168285 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/SignalException
Change 168286 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/SpaceInsideParens
Change 168287 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/SpecialGlobalVars
Change 168288 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/StringLiterals
Change 168289 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/UnneededPercentQ
Change 168290 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/WordArray
Change 168292 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UselessAssignment
Change 168309 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/ClassAndModuleChildren
Change 168310 had a related patch set uploaded by Zfilipin:
WIP Fixed RuboCop offense Metrics/LineLength
Change 168314 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UnusedBlockArgument
Change 168316 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UnusedMethodArgument
Change 168318 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Lint/UselessAccessModifier
Change 168320 had a related patch set uploaded by Zfilipin:
Fixed RuboCop offense Style/AndOr
Change 168277 merged by jenkins-bot:
Fixed RuboCop offense Style/BracesAroundHashParameters
Change 169363 had a related patch set uploaded by Zfilipin:
Fixed Lint/UnusedBlockArgument RuboCop offense
Change 168279 merged by Dduvall:
Use alias_method when aliasing macro-defined attributes
Change 168281 merged by jenkins-bot:
Added custom RuboCop check for Style/DotPosition
Change 168284 merged by jenkins-bot:
Fixed RuboCop offense Style/PercentLiteralDelimiters
Change 170189 had a related patch set uploaded by Dduvall:
Ignoring RuboCop rule Style/Alias
Change 168320 abandoned by Zfilipin:
Fixed RuboCop offense Style/AndOr
Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z
Change 168318 abandoned by Zfilipin:
Fixed RuboCop offense Lint/UselessAccessModifier
Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z
Change 168316 abandoned by Zfilipin:
Fixed RuboCop offense Lint/UnusedMethodArgument
Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z
Change 168314 abandoned by Zfilipin:
Fixed RuboCop offense Lint/UnusedBlockArgument
Reason:
Another big refactoring is happening at the same time: https://gerrit.wikimedia.org/r/#/q/branch:env-abstraction-layer,n,z
Change 170911 had a related patch set uploaded by Zfilipin:
Fixed Style/SpaceAfterComma RuboCop offense
Change 171742 had a related patch set uploaded by Zfilipin:
QA: Update RuboCop configuration file for new RuboCop version
Change 171743 had a related patch set uploaded by Zfilipin:
QA: Fixed Lint/EndAlignment RuboCop offense
Change 171744 had a related patch set uploaded by Zfilipin:
QA: Fixed Lint/ParenthesesAsGroupedExpression RuboCop offense
Change 171745 had a related patch set uploaded by Zfilipin:
QA: Fixed Lint/UnusedBlockArgument RuboCop offense
Change 171746 had a related patch set uploaded by Zfilipin:
QA: Ignoring Metrics/ClassLength RuboCop cop
Change 171747 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/BracesAroundHashParameters RoboCop offense
Change 171748 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/CommentAnnotation RuboCop offense
Change 171749 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/EmptyLines RuboCop offense
Change 171750 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/EmptyLinesAroundClassBody RuboCop offense
Change 171751 had a related patch set uploaded by Zfilipin:
QA: Fixed Style/HashSyntax RuboCop offense
Change 171750 abandoned by Zfilipin:
QA: Fixed Style/EmptyLinesAroundClassBody RuboCop offense
Change 171748 abandoned by Zfilipin:
QA: Fixed Style/CommentAnnotation RuboCop offense
Change 171747 abandoned by Zfilipin:
QA: Fixed Style/BracesAroundHashParameters RoboCop offense
Change 171745 abandoned by Zfilipin:
QA: Fixed Lint/UnusedBlockArgument RuboCop offense
Change 171744 abandoned by Zfilipin:
QA: Fixed Lint/ParenthesesAsGroupedExpression RuboCop offense
Change 171742 abandoned by Zfilipin:
QA: Update RuboCop configuration file for new RuboCop version
Change 171802 had a related patch set uploaded by Lubaochuan:
Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file
Change 172245 had a related patch set uploaded by Vikassy:
[BrowserTest] Fixed Style/CommentAnnotation RuboCop offense
Change 171802 abandoned by Lubaochuan:
Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file
Reason:
Will incorporating this change by amending the previous/original change at https://gerrit.wikimedia.org/r/#/c/171508/
Change 172535 had a related patch set uploaded by Lubaochuan:
Fixed Style/Documentation RuboCop offense
Change 172708 had a related patch set uploaded by Zfilipin:
tests: RuboCop checks .docs/CustomTags.rb
Change 171508 had a related patch set uploaded by Lubaochuan:
Fixed Style/LeadingCommentSpace RuboCop offense Removed Style/LeadingCommentSpace RuboCop offense from .rubocop_todo.yml file
Change 171508 had a related patch set uploaded by Lubaochuan:
Fixed Style/LeadingCommentSpace RuboCop offense
Change 172245 abandoned by Zfilipin:
[BrowserTest] Fixed Style/CommentAnnotation RuboCop offense
Reason:
No activity in a month. Abandoning the commit, since it was my original comment anyway. If you plan to work on this, please restore the commit.
Change 170189 abandoned by Hashar:
Ignoring RuboCop rule Style/Alias
Reason:
This is no more needed. The .rubocop_todo.yml has been removed in master branch and all tests pass.
Change 170189 had a related patch set uploaded (by Hashar):
Ignoring RuboCop rule Style/Alias