Page MenuHomePhabricator
Create Task
Maniphest T65333

VisualEditor: [Regression wmf20] Adding a space after a formatted link throws error Uncaught TypeError: Cannot read property 'constructor' of undefined
Closed, ResolvedPublic
Actions

Description

Screenshot

Steps to reproduce:

1.Add a link
2.Apply format on it like Bold/Strikethrough
3.Now add a space right after that and add a text

Observed Result:
An error appears in the console Uncaught TypeError: Cannot read property 'constructor' of undefined and the text gets added in a weird way: One letter appears before the link and some letters gets typed inside the link text

See the screenshot attached

Test Environment: https://test2.wikipedia.org/
Browser: Chrome Version 26.0.1410.65 & FF 25
OS: MAC OS X 10. 8. 5
Page:https://test2.wikipedia.org/wiki/31stMarChrome?veaction=edit

Version: unspecified
Severity: normal

Attached:

Screen_Shot_2014-03-31_at_3.03.10_PM.png (748×1 px, 284 KB)

Details

Reference
bz63333

Event Timeline

• bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 3:01 AM
• bzimport added projects: VE-deploy-2014-04-03, VisualEditor-ContentEditable.
• bzimport set Reference to bz63333.
Ryasmeen created this task.Mar 31 2014, 10:22 PM
gerritbot added a comment.Apr 2 2014, 7:08 PM

Change 123373 had a related patch set uploaded by Esanders:
Adjust loop counters in word break detection when removing item

https://gerrit.wikimedia.org/r/123373

gerritbot added a comment.Apr 2 2014, 7:14 PM

Change 123373 merged by jenkins-bot:
Adjust loop counters in word break detection when removing item

https://gerrit.wikimedia.org/r/123373

Ryasmeen added a comment.Apr 3 2014, 12:01 AM

Verified the fix on Betalabs

gerritbot added a comment.Apr 7 2014, 10:53 PM

Change 124488 had a related patch set uploaded by Catrope:
Adjust loop counters in word break detection when removing item

https://gerrit.wikimedia.org/r/124488

gerritbot added a comment.Apr 7 2014, 11:22 PM

Change 124488 merged by jenkins-bot:
Adjust loop counters in word break detection when removing item

https://gerrit.wikimedia.org/r/124488

Ryasmeen added a comment.Apr 8 2014, 8:44 PM

Verified the fix on mediawiki.org

Ryasmeen added a comment.Apr 11 2014, 1:03 AM

Verified the fix in production

Jdforrester-WMF added a project: VisualEditor.Nov 27 2014, 12:41 AM
Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 26 2015, 2:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL