Page MenuHomePhabricator

1.22.5 patch includes files in tests subdirectory, but tests wasn't included in 1.22.4
Closed, DeclinedPublic

Description

Reported on irc.

A user using 1.22.4 tried to use http://releases.wikimedia.org/mediawiki/1.22/mediawiki-1.22.5.patch.gz to update to 1.22.5, and diff complained that it couldn't find the files under the ./tests/ directory, since that wasn't included in http://releases.wikimedia.org/mediawiki/1.22/mediawiki-1.22.4.tar.gz.

We either need the tarballs to include the tests/ directory consistently, or the patch shouldn't include them.


Version: 1.22.5
Severity: normal

Details

Reference
bz63337

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:02 AM
bzimport set Reference to bz63337.
bzimport added a subscriber: Unknown Object (MLST).

Mark, doesn't make-release strip out the test folder? If not, it should. I think there's an agreement not to ship tests with the tarball, right?

There is and it should. I'll work on the ignores tonight.

Removing target milestone that was in the past.

If you want this in a specific release, have a good reason AND you are willing to find resources to fix this bug, feel free to change it to something appropriate.

Aklapper lowered the priority of this task from Medium to Lowest.Mar 25 2015, 3:56 PM
Aklapper subscribed.
Paladox subscribed.

We are now at mediawiki 1.27. Mediawiki 1.22 is no longer supported.