Page MenuHomePhabricator
Create Task
Maniphest T65343

checkLess.php doesn't validate skin styles
Closed, ResolvedPublic
Actions

Description

checkLess.php does not validate skin styles. This is a general issue, but is especially problematic for mediawiki.ui and mediawiki.ui.button which package all their styles this way (using 'default').

checkLess.php uses ResourceLoaderFileModule's public getAllStyleFiles method, which only uses $this->styles .

Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54665

Details

Reference
bz63343

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 3:02 AM
• bzimport added a project: MediaWiki-Maintenance-system.
• bzimport set Reference to bz63343.
• Mattflaschen-WMF created this task.Apr 1 2014, 1:47 AM
gerritbot added a comment.Apr 1 2014, 3:20 PM

Change 122838 had a related patch set uploaded by Phuedx:
Make checkLess.php validate skin styles

https://gerrit.wikimedia.org/r/122838

gerritbot added a comment.Jun 17 2014, 7:43 PM

Change 122838 merged by jenkins-bot:
Make ResourceLoaderFileModule#getAllStyleFiles include all skin styles

https://gerrit.wikimedia.org/r/122838

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL