Adding content to an empty table cell written in inline form results in the serialised wikitext being in the one-cell-per-line format
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lokal_Profil
	Apr 1 2014, 10:14 AM

Description

Intention:
Add a value to an empty cell in a table using VE

Steps to Reproduce:

You need a page with a table with at least one empty cell (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/User:ESanders_(WMF)/sandbox/T65356)
Open page for VE editing
Double click on the empty cell, then add some text
Show the wikitext diff in the save dialog

Actual Results:
In addition to the entered text a line-break is added

Expected Results:
No additional line-break

Reproducible: Always

Note that this does not happen for cells which already contains a value

Version: unspecified
Severity: normal

Details

Reference: bz63356

	Subject	Repo	Branch	Lines +/-
	Update VE core submodule to master (145cf95d8)	mediawiki/extensions/VisualEditor	master	+3 -3
	Use wrapper paragraphs in empty branch nodes	VisualEditor/VisualEditor	master	+23 -13

Customize query in gerrit

Related Objects

Mentioned Here: rGVED145cf95d8950: Merge "Use wrapper paragraphs in empty branch nodes"

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:03 AM

• bzimport added projects: Browser-Support-Firefox, Parsoid-Serializer.

• bzimport set Reference to bz63356.

Lokal_Profil created this task.Apr 1 2014, 10:14 AM

Created attachment 14994
Screenshot

Screenshot showing the result to the source of editing a filled and an empty cell using VE.

Attached:

Screenshot_from_2014-04-01_12:12:32.png (339×1 px, 15 KB)

Bug 73215 has been marked as a duplicate of this bug. ***

Arlolra added a project: Parsoid.Nov 25 2014, 6:59 PM

Arlolra set Security to None.

Arlolra triaged this task as Medium priority.Nov 26 2014, 10:56 PM

Arlolra merged a task: T75215: VisualEditor: Tables wikitext can be inconsistent.

Arlolra added a subscriber: Etonkovidova.

Arlolra subscribed.

Arlolra removed a project: Browser-Support-Firefox.Feb 14 2015, 11:03 PM

Hmm, the difference seems to be that if you click once on the empty cell and start typing, VE doesn't wrap the text in a <p>,

<td data-parsoid="{&quot;stx_v&quot;:&quot;row&quot;,&quot;autoInsertedEnd&quot;:true,&quot;dsr&quot;:[38,41,2,0]}">haha</td>

However, doubling clicking and then typing does,

<td data-parsoid="{&quot;stx_v&quot;:&quot;row&quot;,&quot;autoInsertedEnd&quot;:true,&quot;dsr&quot;:[38,41,2,0]}"> <p>haha</p></td>

Serializing the paragraph introduces a newline which would break the row syntax, so Parsoid switches the other format. I suppose we could be smarter about the p/td nl constraints, or VE maybe avoid introducing the paragraph to begin with?

Arlolra added a project: VisualEditor.Mar 29 2017, 4:29 PM

ssastry added a subscriber: Esanders.Mar 29 2017, 4:30 PM

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.Mar 29 2017, 4:34 PM

Jdforrester-WMF set the point value for this task to 1.

Krinkle unsubscribed.Jan 12 2018, 11:52 PM

LGoto moved this task from Needs Triage to Backlog on the Parsoid board.Feb 17 2020, 4:43 PM

Arlolra moved this task from Backlog to Bugs & Crashers on the Parsoid board.Feb 26 2021, 5:59 PM

Change 667411 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Use wrapper paragraphs in empty branch nodes

https://gerrit.wikimedia.org/r/667411

gerritbot added a project: Patch-For-Review.Feb 28 2021, 4:12 PM

Esanders updated the task description. (Show Details)Feb 28 2021, 4:15 PM

Esanders removed the point value for this task.

Esanders edited projects, added Editing-team (Kanban Board); removed Parsoid, Parsoid-Serializer.

Esanders moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.

Esanders claimed this task.Feb 28 2021, 11:11 PM

Change 667411 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Use wrapper paragraphs in empty branch nodes

https://gerrit.wikimedia.org/r/667411

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Mar 10 2021, 10:58 PM

matmarex edited projects, added Editing QA; removed Patch-For-Review.

Change 670606 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (145cf95d8)

https://gerrit.wikimedia.org/r/670606

gerritbot added a project: Patch-For-Review.Mar 10 2021, 11:01 PM

matmarex removed a project: Editing QA.Mar 10 2021, 11:06 PM

matmarex moved this task from QA to Code Review on the Editing-team (Kanban Board) board.

• Elitre unsubscribed.Mar 11 2021, 12:52 PM

matmarex removed a project: Patch-For-Review.Mar 11 2021, 8:09 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.

Change 670606 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (145cf95d8)

https://gerrit.wikimedia.org/r/670606

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 11 2021, 9:00 PM

MBinder_WMF added a project: Editing QA.Mar 17 2021, 4:12 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Mar 18 2021, 12:03 AM

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.

• ppelberg closed this task as Resolved.Mar 18 2021, 10:18 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 18 2021, 10:18 PM

	F13280: Screenshot_from_2014-04-01_12:12:32.png
	Nov 22 2014, 3:03 AM

Adding content to an empty table cell written in inline form results in the serialised wikitext being in the one-cell-per-line formatClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Adding content to an empty table cell written in inline form results in the serialised wikitext being in the one-cell-per-line format
Closed, ResolvedPublic
Actions