Page MenuHomePhabricator

UI Icons file 404 Not Found
Closed, ResolvedPublic

Description

ui-icons_888888_256x240.png is not found. Disabled button icons are normally seen when activating an edit.

Code from toolbarbutton.css:
.wikibase-toolbarbutton-disabled .ui-icon {
background-image: url(../../../../../../../../resources/jquery.ui/themes/default/images/ui-icons_888888_256x240.png);

Relative path is incorrect due to new Wikidata extension path that moves Wikibase down two additional levels from root. Problem is how to make Wikibase relative path independent of Wikidata extension.


Version: unspecified
Severity: normal
Whiteboard: u=dev c=frontend p=0

Details

Reference
bz63363

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:03 AM
bzimport set Reference to bz63363.
bzimport added a subscriber: Unknown Object (MLST).

We already tackled this path issue in most places. Is this particular path hardcoded in the css?

If so, and if it points to a core file, then this seems to be inherently broken. MediaWiki has an "extension path" setting, which allows you to put stuff somewhere else. If you whare to set this to foo/bar, then this would also break.

Created attachment 14996
Missing gray arrows highlighted in green

I can confirm that this really is a bug, see the screenshot. However, it's very, very minor. What the "888888" image does is to make disabled up/down arrows gray. Because of the path not working in production these gray arrows disappear. Which is purely cosmetic. Gray arrows can't be used anyway.

Attached:

Bildschirmfoto_vom_2014-04-01_21:26:27.png (244×969 px, 18 KB)