Page MenuHomePhabricator

review backend part of entity suggester (python code)
Closed, ResolvedPublic

Description

https://github.com/Wikidata-lib/PropertySuggester-Python


Version: unspecified
Severity: major
Whiteboard: u=dev c=backend p=8 s=2014-05-20

Details

Reference
bz63368

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 3:04 AM
bzimport set Reference to bz63368.
bzimport added a subscriber: Unknown Object (MLST).

Review of the PHP part is bug 63224.

Review is done from Wikidata-Team side.
Pending WMF review now.

Looks fine. The WMF may not be able to run this on the cluster, since we don't make pip available, and I'm not sure if we have ujson available. Might have to have ops install that.

In general, I'd be more happy if this was run on labs, but it shouldn't harm the cluster if we run it there.

christian.dullweber wrote:

Thanks for the review. ujson is optional and only gives a small speedup. the other requirements are only for testing.
The code could run on labs. The resulting csv file only needs to be accessible to the maintenance script for the import.