https://github.com/Wikidata-lib/PropertySuggester-Python
Version: unspecified
Severity: major
Whiteboard: u=dev c=backend p=8 s=2014-05-20
https://github.com/Wikidata-lib/PropertySuggester-Python
Version: unspecified
Severity: major
Whiteboard: u=dev c=backend p=8 s=2014-05-20
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T66956 Install Entity Suggester on the Wikidata Demo system | |||
Resolved | None | T48555 Entity suggester for Wikidata | |||
Resolved | None | T65368 review backend part of entity suggester (python code) | |||
Resolved | • csteipp | T68378 Security review of Property Suggestor - python part | |||
Resolved | None | T68379 Perf review of Property Suggester - python part |
Looks fine. The WMF may not be able to run this on the cluster, since we don't make pip available, and I'm not sure if we have ujson available. Might have to have ops install that.
In general, I'd be more happy if this was run on labs, but it shouldn't harm the cluster if we run it there.
christian.dullweber wrote:
Thanks for the review. ujson is optional and only gives a small speedup. the other requirements are only for testing.
The code could run on labs. The resulting csv file only needs to be accessible to the maintenance script for the import.