Use Maps and Sets in WikiConfig
Closed, DeclinedPublic
Actions

Assigned To

Authored By

	ssastry
	Apr 1 2014, 3:23 PM

Description

mediawiki.WikiConfig.js uses {} to implements maps and sets. We should go in and replace those with es6 maps and sets like in the most of the codebase.

Version: unspecified
Severity: enhancement

Details

Reference: bz63370

Related Objects

Mentioned In: T195227: Template serialization can dirty diff transclusions with 'constructor' as a template arg
T105997: F13. Parsoid crashes on __proto__

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:04 AM

• bzimport added projects: Parsoid, good first task.

• bzimport set Reference to bz63370.

ssastry created this task.Apr 1 2014, 3:23 PM

In the interest of performance we should perhaps only use Map / Set where the keys are actually user-provided. The es6 shim uses objects under the hood right now, and is slower than native objects.

Change 151068 had a related patch set uploaded by Arlolra:
Use a map for the interwikiMap

https://gerrit.wikimedia.org/r/151068

Change 151068 merged by jenkins-bot:
Use a map for the interwikiMap

https://gerrit.wikimedia.org/r/151068

All patches mentioned in this report were merged or abandoned - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

There's more work to do ... at least audit as suggested in comment 1.

Arlolra triaged this task as Low priority.Nov 25 2014, 9:35 PM

ssastry moved this task from Needs Triage to Maintenance / Tech-Debt on the Parsoid board.Dec 20 2014, 1:09 AM

• marcoil removed • marcoil as the assignee of this task.Feb 10 2015, 3:16 PM

• marcoil added a project: Technical-Debt.

• marcoil set Security to None.

• marcoil moved this task from Maintenance / Tech-Debt to Needs Triage on the Parsoid board.Feb 13 2015, 12:52 PM

Ricordisamoa subscribed.Jul 16 2015, 3:51 PM

• Mattflaschen-WMF mentioned this in T105997: F13. Parsoid crashes on __proto__.Jul 16 2015, 6:47 PM

Krinkle subscribed.Apr 27 2017, 7:15 AM

Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptApr 27 2017, 7:15 AM

Krinkle awarded a token.Apr 27 2017, 7:15 AM