Page MenuHomePhabricator
Create Task
Maniphest T65410

Fatal error in change dispatcher when restoring an item
Closed, DeclinedPublic
Actions

Description

Notice: No such revision found for Q50: 180 [Called from Wikibase\ChangeHandler::coalesceRuns in /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php at line 367] in /Library/WebServer/Documents/php-master/includes/debug/Debug.php on line 303

Call Stack:

0.0007     750896   1. {main}() /Library/WebServer/Documents/php-master/maintenance/runJobs.php:0
0.0023    1281904   2. require_once('/Library/WebServer/Documents/php-master/maintenance/doMaintenance.php') /Library/WebServer/Documents/php-master/maintenance/runJobs.php:268
0.0682   17603992   3. RunJobs->execute() /Library/WebServer/Documents/php-master/maintenance/doMaintenance.php:104
0.1093   22078416   4. Wikibase\ChangeNotificationJob->run() /Library/WebServer/Documents/php-master/maintenance/runJobs.php:103
0.3250   31840664   5. Wikibase\ChangeHandler->handleChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/lib/includes/ChangeNotificationJob.php:128
0.3250   31840664   6. Wikibase\ChangeHandler->coalesceChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:466
1.4623   37278560   7. Wikibase\ChangeHandler->coalesceRuns() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:415
1.4670   37521728   8. wfWarn() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:367
1.4670   37521952   9. MWDebug::warning() /Library/WebServer/Documents/php-master/includes/GlobalFunctions.php:1144
1.4671   37523104  10. MWDebug::sendMessage() /Library/WebServer/Documents/php-master/includes/debug/Debug.php:157
1.4671   37523416  11. trigger_error() /Library/WebServer/Documents/php-master/includes/debug/Debug.php:303

Warning: array_merge(): Argument #1 is not an array in /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php on line 298

Call Stack:

0.0007     750896   1. {main}() /Library/WebServer/Documents/php-master/maintenance/runJobs.php:0
0.0023    1281904   2. require_once('/Library/WebServer/Documents/php-master/maintenance/doMaintenance.php') /Library/WebServer/Documents/php-master/maintenance/runJobs.php:268
0.0682   17603992   3. RunJobs->execute() /Library/WebServer/Documents/php-master/maintenance/doMaintenance.php:104
0.1093   22078416   4. Wikibase\ChangeNotificationJob->run() /Library/WebServer/Documents/php-master/maintenance/runJobs.php:103
0.3250   31840664   5. Wikibase\ChangeHandler->handleChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/lib/includes/ChangeNotificationJob.php:128
0.3250   31840664   6. Wikibase\ChangeHandler->coalesceChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:466
1.5106   37593064   7. Wikibase\ChangeHandler->coalesceRuns() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:415
1.5114   37595968   8. Wikibase\ChangeHandler->mergeChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:387
1.5143   37615896   9. array_merge() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:298

Catchable fatal error: Argument 1 passed to Wikibase\EntityChange::setMetadata() must be an array, null given, called in /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php on line 298 and defined in /Library/WebServer/Documents/php-master/extensions/Wikibase/lib/includes/changes/EntityChange.php on line 156

Call Stack:

0.0007     750896   1. {main}() /Library/WebServer/Documents/php-master/maintenance/runJobs.php:0
0.0023    1281904   2. require_once('/Library/WebServer/Documents/php-master/maintenance/doMaintenance.php') /Library/WebServer/Documents/php-master/maintenance/runJobs.php:268
0.0682   17603992   3. RunJobs->execute() /Library/WebServer/Documents/php-master/maintenance/doMaintenance.php:104
0.1093   22078416   4. Wikibase\ChangeNotificationJob->run() /Library/WebServer/Documents/php-master/maintenance/runJobs.php:103
0.3250   31840664   5. Wikibase\ChangeHandler->handleChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/lib/includes/ChangeNotificationJob.php:128
0.3250   31840664   6. Wikibase\ChangeHandler->coalesceChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:466
1.5106   37593064   7. Wikibase\ChangeHandler->coalesceRuns() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:415
1.5114   37595968   8. Wikibase\ChangeHandler->mergeChanges() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:387
1.5147   37617064   9. Wikibase\EntityChange->setMetadata() /Library/WebServer/Documents/php-master/extensions/Wikibase/client/includes/ChangeHandler.php:298

Version: master
Severity: normal
Whiteboard: u=dev c=backend p=3 s=2014-04-01

Details

Reference
bz63410

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:07 AM
• bzimport added a project: MediaWiki-extensions-WikibaseClient.
• bzimport set Reference to bz63410.
• bzimport added a subscriber: Unknown Object (MLST).
aude created this task.Apr 2 2014, 11:50 AM
aude added a comment.Apr 7 2014, 9:45 AM

I cannot reproduce this now. It could be I had something strange in my wiki database.

even if this is not an issue after all, there still are places in the change handler code that can be made more robust.

aude added a comment.Apr 7 2014, 10:32 AM

we can check the dispatcher log when we deploy, but I think this is not an issue. (not in the branch, not in master)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL