Page MenuHomePhabricator
Create Task
Maniphest T65454

Code Hygiene: Standardise between forEach and $.each usage
Closed, ResolvedPublic
Actions

Description

Version: unspecified
Severity: normal

Details

Reference
bz63454

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 3:09 AM
• bzimport added a project: Don't use – MobileFrontend-Hygiene.
• bzimport set Reference to bz63454.
Jdlrobson created this task.Apr 2 2014, 11:15 PM
• bzimport added a comment.Apr 2 2014, 11:20 PM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1892

Jdlrobson added a comment.Sep 25 2014, 4:14 PM

forEach is used in api.js, PageApi.js, application.js and View.js

Polyfills were dropped in I55629aca3646367694c23b2e3fca6f2db31a96f7 but we probably want to support IE8?

gerritbot added a comment.Oct 6 2014, 11:57 PM

Change 165135 had a related patch set uploaded by Robmoen:
Standardize on jQuery.each vs forEach

https://gerrit.wikimedia.org/r/165135

gerritbot added a comment.Oct 7 2014, 12:33 AM

Change 165135 merged by jenkins-bot:
Standardize on jQuery.each vs forEach

https://gerrit.wikimedia.org/r/165135

Jdforrester-WMF edited projects, added Technical-Debt, MobileFrontend-General-or-Unknown; removed Don't use – MobileFrontend-Hygiene.Dec 8 2014, 9:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL