Page MenuHomePhabricator

mediawiki/ruby/api repo should run unit tests after every patch set
Closed, ResolvedPublic

Description

https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/ruby/api

To run unit tests, run rspec from the root of the repo:

$ rspec
I, [2014-04-03T12:02:33.907066 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.907137 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.908769 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.908822 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.924301 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.924344 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.951007 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.951100 #3818] DEBUG -- response: set-cookie: "prefixSession=789; path=/; domain=localhost; HttpOnly"
I, [2014-04-03T12:02:33.951279 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.951309 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.952320 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.952348 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.953119 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.953166 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.954511 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.954543 #3818] DEBUG -- response: set-cookie: "prefixSession=789; path=/; domain=localhost; HttpOnly"
I, [2014-04-03T12:02:33.954696 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.954727 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.955615 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.955643 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.982678 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.982728 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.983815 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.983843 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.984428 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.984462 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.985388 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.985421 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.986208 #3818]  INFO -- : get http://localhost/api.php?action=tokens&format=json&type=edit
D, [2014-04-03T12:02:33.986243 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
I, [2014-04-03T12:02:33.988652 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.988686 #3818] DEBUG -- response: 
I, [2014-04-03T12:02:33.988850 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.988882 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.989839 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.989867 #3818] DEBUG -- response: 
.*I, [2014-04-03T12:02:33.990917 #3818]  INFO -- : get http://localhost/api.php?action=tokens&format=json&type=delete
D, [2014-04-03T12:02:33.990978 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
I, [2014-04-03T12:02:33.993307 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.993336 #3818] DEBUG -- response: 
I, [2014-04-03T12:02:33.993461 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.993513 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.994423 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.994450 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.995175 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.995208 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.996103 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.996130 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.996787 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.996820 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.998175 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.998206 #3818] DEBUG -- response: set-cookie: "prefixSession=789; path=/; domain=localhost; HttpOnly"
I, [2014-04-03T12:02:33.998330 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.998360 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:33.999215 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:33.999242 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:33.999822 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:33.999856 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:34.001270 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:34.001311 #3818] DEBUG -- response: set-cookie: "prefixSession=789; path=/; domain=localhost; HttpOnly"
I, [2014-04-03T12:02:34.001445 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:34.001495 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:34.002342 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:34.002375 #3818] DEBUG -- response: 
.I, [2014-04-03T12:02:34.003543 #3818]  INFO -- : post http://localhost/api.php
D, [2014-04-03T12:02:34.003593 #3818] DEBUG -- request: User-Agent: "Faraday v0.9.0"
Content-Type: "application/x-www-form-urlencoded"
I, [2014-04-03T12:02:34.004627 #3818]  INFO -- Status: 200
D, [2014-04-03T12:02:34.004655 #3818] DEBUG -- response: 
.

Pending:
  MediawikiApi::Client#create_page when API returns Success returns a MediawikiApi::Page
    # Not yet implemented
    # ./spec/client_spec.rb:83

Finished in 0.3394 seconds
12 examples, 0 failures, 1 pending

Version: wmf-deployment
Severity: normal
Whiteboard: zfilipin

Details

Reference
bz63467

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 3:10 AM
bzimport set Reference to bz63467.
bzimport added a subscriber: Unknown Object (MLST).
  • next step: check if unit tests are green
  • check if there are missing unit tests
  • if so, write them

@hashar, @dduvall: The last commit for the repository has mediawiki-ruby-api-bundle-rspec job and it is green:

https://gerrit.wikimedia.org/r/#/c/175870/
https://integration.wikimedia.org/ci/job/mediawiki-ruby-api-bundle-rspec/7/console

Closing this task as resolved. Please reopen if there is something left to do.

zeljkofilipin reopened this task as Open.
zeljkofilipin closed this task as Resolved.
zeljkofilipin updated the task description. (Show Details)